Add function to create spoly from an array of numbers in radians #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the answer to both question is "yes". Mind that besides the parameter being NULL, individual array elements might also be NULL. |
vitcpp
requested changes
Oct 30, 2023
vitcpp
requested changes
Oct 31, 2023
8000
|
@esabol I think, everything ok except of some trivial formatting changes. Thank you! |
|
@esabol I'm ok to accept the patch. Could you please squash the commits? |
This was referenced Nov 1, 2023
Closed
2cbb5b0 to
0fcfa36
Compare
|
Rebased and squashed. Ready to merge whenever you are. Thank you for your reviews, @vitcpp ! |
vitcpp
approved these changes
Nov 2, 2023
|
It seems I'm the only reviewer. Lets merge it, since the risks to break the pgpshere are minimal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #95, this pull request adds a constructor function to create an spoly from an array of numbers in radians. It is very similar to spoly_deg() except without the calls to
deg_to_rad().Question 1: Can the spoly(float8[]) function be marked PARALLEL SAFE? My reading of the documentation for PARALLEL SAFE doesn't mention anything about accessing arrays or allocating memory, so I think it should be.
Question 2: Can it be marked STRICT?
select spoly(NULL::float8[])returns null, I believe.If the answer to either or both questions, I would like to make the same change(s) to
spoly_degalso.