-
Notifications
You must be signed in to change notification settings - Fork 2.5k
chore: Move boto3 extra from s3fs in dev requirements
#25667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: The package `s3fs==2025.12.0` does not have an extra named `boto3`
boto3 option from s3fsboto3 option from s3fs
boto3 option from s3fsboto3 option from s3fs
boto3 option from s3fsboto3 extra from s3fs
|
Caused by fsspec/s3fs#995 |
nameexhaustion
requested changes
Dec 9, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we ensure boto3 is kept as a dependency by adding it to the requirements?
nameexhaustion
approved these changes
Dec 9, 2025
boto3 extra from s3fsboto3 extra from s3fs requirements
boto3 extra from s3fs requirementsboto3 extra from s3fs requirements
boto3 extra from s3fs requirementsboto3 extra from s3fs in dev requirements
boto3 extra from s3fs in dev requirementsboto3 extra from s3fs in dev requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-io-cloud
Area: reading/writing to cloud storage
fix
Bug fix
internal
An internal refactor or improvement
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this when setting up locally
There doesn't seem to be any boto3 extras in the repo either (assuming I have the correct one) https://github.com/fsspec/s3fs