8000 feat: Allow `hash` for all `List` dtypes by coastalwhite · Pull Request #25372 · pola-rs/polars · GitHub
[go: up one dir, main page]
Skip to content
  • Insights

    • feat: Allow hash for all List dtypes #25372

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Merged
    ritchie46 merged 1 commit into from
    Nov 17, 2025
    Merged

    feat: Allow hash for all List dtypes #25372

    ritchie46 merged 1 commit into from
    Nov 17, 2025

    Conversation

    @coastalwhite
    Copy link
    Collaborator
    @coastalwhite coastalwhite commented Nov 16, 2025 •
    edited
    Loading

    Fixes #21523.
    Fixes #13950.

    @github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Nov 16, 2025
    @codecov
    Copy link
    codecov bot commented Nov 16, 2025 •
    edited
    Loading

    Codecov Report

    ✅ All modified and coverable lines are covered by tests.
    ✅ Project coverage is 82.09%. Comparing base (57074c9) to head (4f16d71).
    ⚠️ Report is 9 commits behind head on main.

    Additional details and impacted files 
    @@           Coverage Diff           @@
##             main   #25372   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files        1711     1710    -1     
  Lines      237304   237249   -55     
  Branches     3013     3013           
=======================================
- Hits       194807   194766   -41     
+ Misses      41724    41710   -14     
  Partials      773      773

    ☔ View full report in Codecov by Sentry.
    📢 Have feedback on the report? Share it here.

    🚀 New features to boost your workflow:
    • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

    @mcrumiller
    Copy link
    Contributor
    mcrumiller commented Nov 16, 2025

    Can we do array too?

    @coastalwhite
    Copy link
    Collaborator Author
    coastalwhite commented Nov 16, 2025

    Can we do array too?

    Should now support everything, I think ?

    @mcrumiller
    Copy link
    Contributor
    mcrumiller commented Nov 16, 2025

    Ahh yup. Awesome!

    @ritchie46 ritchie46 merged commit 5464cc8 into pola-rs:main Nov 17, 2025
    26 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @ritchie46 ritchie46 ritchie46 approved these changes

    @orlp orlp Awaiting requested review from orlp orlp is a code owner

    @c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

    Assignees

    No one assigned

    Labels

    enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    hash() list of string PanicException hash list of String

    3 participants

    @coastalwhite @mcrumiller @ritchie46
    0