perf: Return references from aexpr_to_leaf_names_iter
#25319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakubValtar
commented
Nov 13, 2025
Comment on lines
+248
to
+251
| arena: &'_ Arena<AExpr>, | ||
| ) -> impl Iterator<Item = &'_ PlSmallStr> + '_ { | ||
| aexpr_to_column_nodes_iter(node, arena).map(|node| match arena.get(node.0) { | ||
| AExpr::Column(name) => name.clone(), | ||
| AExpr::Column(name) => name, |
Collaborator
Author
There was a problem hiding this comment.
note: This is the main change.
Comment on lines
-260
to
-261
| pub fn aexpr_to_leaf_name(node: Node, arena: &Arena<AExpr>) -> PlSmallStr { | ||
| aexpr_to_leaf_names_iter(node, arena).next().unwrap() |
Collaborator
Author
There was a problem hiding this comment.
note: I removed this one, it is not used.
nameexhaustion
approved these changes
Nov 13, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25319 +/- ##
==========================================
- Coverage 81.95% 81.93% -0.02%
==========================================
Files 1712 1712
Lines 237225 237224 -1
Branches 3011 3011
==========================================
- Hits 194417 194371 -46
- Misses 42035 42080 +45
Partials 773 773 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid cloning in a few places.