8000 fix: Fix incorrect `drop_nans()` result when used in `group_by()` / `over()` by coastalwhite · Pull Request #25146 · pola-rs/polars · GitHub < 8000 meta name="theme-color" content="#1e2327">
[go: up one dir, main page]
Skip to content

fix: Fix incorrect drop_nans() result when used in group_by() / over() #25146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coastalwhite merged 1 commit into from
Nov 3, 2025
Merged

fix: Fix incorrect drop_nans() result when used in group_by() / over() #25146

coastalwhite merged 1 commit into from
Nov 3, 2025

Conversation

@co 8000 astalwhite
Copy link
Collaborator
@coastalwhite coastalwhite commented Nov 3, 2025

Fixes #25145.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Nov 3, 2025
@codecov
Copy link
codecov bot commented Nov 3, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.81%. Comparing base (ed23bd6) to head (a0c3c2c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #25146      +/-   ##
==========================================
+ Coverage   81.79%   81.81%   +0.02%     
==========================================
  Files        1709     1709              
  Lines      236260   236261       +1     
  Branches     3005     3005              
==========================================
+ Hits       193245   193296      +51     
+ Misses      42247    42197      -50     
  Partials      768      768

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coastalwhite coastalwhite merged commit eba9beb into pola-rs:main Nov 3, 2025
29 checks passed
@coastalwhite coastalwhite deleted the fix/drop-nans-group-by-25145 branch November 3, 2025 20:49
@nameexhaustion nameexhaustion mentioned this pull request Nov 4, 2025
Closed
2 tasks
@nameexhaustion nameexhaustion changed the title fix: Invert drop_nans filtering in group-by context fix: Fix incorrect result when using drop_nans() in group_by() / over() Nov 4, 2025
@nameexhaustion nameexhaustion changed the title fix: Fix incorrect result when using drop_nans() in group_by() / over() fix: Fix incorrect drop_nans() result when used in group_by() / over() Nov 4, 2025
ritchie46 pushed a commit that referenced this pull request Nov 8, 2025
@coastalwhite @ritchie46
fix: Invert drop_nans filtering in group-by context (#25146)
8045269
ritchie46 pushed a commit that referenced this pull request Nov 8, 2025
@coastalwhite @ritchie46
fix: Invert drop_nans filtering in group-by context (#25146)
c19e4c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees

No one assigned

Labels

fix Bug fix python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

drop_nans in group_by context drops everything that is not NaN since 1.35.0

1 participant

@coastalwhite
0