8000 fix: Return the correct string-case `Expr` reprs by alexander-beedie · Pull Request #25101 · pola-rs/polars · GitHub
[go: up one dir, main page]
Skip to content

fix: Return the correct string-case Expr reprs #25101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coastalwhite merged 1 commit into from
Oct 30, 2025
Merged

fix: Return the correct string-case Expr reprs #25101

coastalwhite merged 1 commit into from
Oct 30, 2025
+6 −6

Conversation

@alexander-beedie
Copy link
Collaborator
@alexander-beedie alexander-beedie commented Oct 30, 2025

The string-case Exprs (upper, lower, title) were dropping the leading "to_" in their repr output.

Example

Before

pl.col("strcol").str.to_lowercase()
# <Expr ['col("strcol").str.lowercase()'] at 0x119598750>

After

pl.col("strcol").str.to_lowercase()
# <Expr ['col("strcol").str.to_lowercase…'] at 0x10E198850>

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 30, 2025
@codecov
Copy link
codecov bot commented Oct 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.74%. Comparing base (5446ac7) to head (02b1775).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rates/polars-plan/src/dsl/function_expr/strings.rs 0.00% 3 Missing ⚠️
...lars-plan/src/plans/aexpr/function_expr/strings.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #25101      +/-   ##
==========================================
- Coverage   81.75%   81.74%   -0.01%     
==========================================
  Files        1707     1707              
  Lines      235608   235608              
  Branches     3005     3005              
==========================================
- Hits       192631   192609      -22     
- Misses      42209    42231      +22     
  Partials      768      768

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coastalwhite coastalwhite merged commit 6bf4153 into pola-rs:main Oct 30, 2025
24 checks passed
@alexander-beedie alexander-beedie deleted the expr-stringcase-repr branch October 30, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

1 more reviewer

@coastalwhite coastalwhite coastalwhite approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix Bug fix python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexander-beedie @coastalwhite
0