fix(python): Fix scan_iceberg() storage options not taking effect
#24574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scan_iceberg() storage options not taking effectscan_iceberg() storage options not taking effect
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24574 +/- ##
==========================================
- Coverage 81.76% 81.75% -0.01%
==========================================
Files 1686 1686
Lines 229972 229993 +21
Branches 2971 2974 +3
==========================================
- Hits 188045 188041 -4
- Misses 41174 41199 +25
Partials 753 753 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ritchie46
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
storage_optionsparameter toscan_iceberg()currently takes configuration keys defined at https://py.iceberg.apache.org/configuration/#fileio rather than the ones used by object store. This PR adds a conversion step before passing them to the native reader.