8000 fix: Do not propagate struct of nulls with null by dsprenkels · Pull Request #24420 · pola-rs/polars · GitHub
[go: up one dir, main page]
Skip to content

fix: Do not propagate struct of nulls with null #24420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orlp merged 2 commits into from
Sep 9, 2025
Merged

fix: Do not propagate struct of nulls with null #24420

orlp merged 2 commits into from
Sep 9, 2025

Conversation

@dsprenkels
Copy link
Collaborator
@dsprenkels dsprenkels commented Sep 9, 2025 •
edited
Loading

Fixes #23955

@dsprenkels dsprenkels changed the title fix: Can we fix #23955 by just removing this match arm? fix: Do not propagate struct of nulls with null Sep 9, 2025
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Sep 9, 2025
@dsprenkels dsprenkels marked this pull request as ready for review September 9, 2025 13:18
@codecov
Copy link
codecov bot commented Sep 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.77%. Comparing base (1dc7792) to head (22b39ef).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #24420   +/-   ##
=======================================
  Coverage   81.76%   81.77%           
=======================================
  Files        1680     1680           
  Lines      227840   227888   +48     
  Branches     2920     2920           
=======================================
+ Hits       186304   186356   +52     
+ Misses      40805    40801    -4     
  Partials      731      731

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@orlp orlp merged commit 038168a into pola-rs:main Sep 9, 2025
30 of 31 checks passed
@dsprenkels dsprenkels deleted the issue-23955_struct_null_popagation branch September 10, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orlp orlp orlp approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees

No one assigned

Labels

fix Bug fix python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

odd behaviour with struct .with_fields() when dealing with null values

2 participants

@dsprenkels @orlp
0