8000 chore: add titles to notification elements for accessibility by jiridostal · Pull Request #13478 · podman-desktop/podman-desktop · GitHub
[go: up one dir, main page]
Skip to content

chore: add titles to notification elements for accessibility #13478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2025
Merged

chore: add titles to notification elements for accessibility #13478

merged 2 commits into from
Aug 1, 2025

Conversation

jiridostal
Copy link
Contributor

What does this PR do?

This PR adds titles to icons and close button in notification, utilising the newly added parameter.
This is for accessibility and testing purposes.

follow-up on #13380

  • Tests are covering the bug fix or the new feature

@jiridostal
chore: add accesibility titles to notification elements
739f7b2 
Signed-off-by: Jiri Dostal <jdostal@redhat.com>
@jiridostal
chore: update tests to check notification titles
18b7cb7 
Signed-off-by: Jiri Dostal <jdostal@redhat.com>
@jiridostal jiridostal requested review from benoitf and a team as code owners August 1, 2025 12:49
@jiridostal jiridostal requested review from dgolovin and SoniaSandler and removed request for a team August 1, 2025 12:49
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Aug 1, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

This change updates the NotificationCardItem component and its associated test suite. In the component, title attributes are added to both the notification type icon and the delete button icon for improved accessibility and descriptive tooltips. The test suite is updated to assert the presence and correctness of these title attributes, and to use more specific queries for icon elements based on their title values. No changes are made to logic, event handling, or exported entities.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~6 minutes

Possibly related PRs

Suggested reviewers

  • benoitf
  • eqqe

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3227bc8 and 18b7cb7.

📒 Files selected for processing (2)
  • packages/renderer/src/lib/dashboard/NotificationCardItem.spec.ts (4 hunks)
  • packages/renderer/src/lib/dashboard/NotificationCardItem.svelte (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: linter, formatters
  • GitHub Check: unit tests / ubuntu-24.04
  • GitHub Check: unit tests / macos-15
  • GitHub Check: unit tests / windows-2025
  • GitHub Check: typecheck
  • GitHub Check: macOS
  • GitHub Check: Linux
  • GitHub Check: Windows
  • GitHub Check: build website
  • GitHub Check: smoke e2e tests (production)
  • GitHub Check: smoke e2e tests (development)
🔇 Additional comments (6)
packages/renderer/src/lib/dashboard/NotificationCardItem.svelte (2)

38-38: Excellent accessibility enhancement!

The title attribute provides a descriptive tooltip that includes the notification type, improving user experience while maintaining the existing component structure.

61-63: Good accessibility improvement for the delete button.

The title attribute complements the existing aria-label, providing both screen reader support and visual tooltip functionality for better accessibility.

packages/renderer/src/lib/dashboard/NotificationCardItem.spec.ts (4)

55-55: Good test coverage for delete button accessibility.

The assertion properly validates the new title attribute for the delete button, ensuring the accessibility improvement is tested.

70-84: Improved test approach using title-based element selection.

The updated test methodology using getByTitle with partial matching is more robust and directly validates the accessibility improvements. The assertion correctly verifies the complete title text format.

95-109: Consistent test pattern for warning notifications.

The test properly validates the icon title for warning notifications, maintaining consistency with the other notification type tests.

120-134: Complete test coverage for error notifications.

The test validates the icon title for error notifications, ensuring all notification types have proper accessibility testing coverage.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

sourcery-ai[bot]
sourcery-ai bot reviewed Aug 1, 2025
View reviewed changes
Copy link
Contributor
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jiridostal - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov Codecov
Copy link
codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

simonrey1
simonrey1 approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor
@simonrey1 simonrey1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up :) LGTM

@cdrage cdrage merged commit 50e4d4c into podman-desktop:main Aug 1, 2025
21 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.21.0 milestone Aug 1, 2025
@coderabbitai coderabbitai bot mentioned this pull request Aug 12, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@cdrage cdrage cdrage approved these changes

@simonrey1 simonrey1 simonrey1 approved these changes

@benoitf benoitf Awaiting requested review from benoitf benoitf is a code owner

@dgolovin dgolovin Awaiting requested review from dgolovin dgolovin is a code owner automatically assigned from podman-desktop/reviewers

@SoniaSandler SoniaSandler Awaiting requested review from SoniaSandler SoniaSandler is a code owner automatically assigned from podman-desktop/reviewers

@gastoner gastoner Awaiting requested review from gastoner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jiridostal @cdrage @simonrey1 @podman-desktop-bot
0