8000 chore(test): remove the skip for podman machine onboarding e2e tests by odockal · Pull Request #13454 · podman-desktop/podman-desktop · GitHub
[go: up one dir, main page]
Skip to content

chore(test): remove the skip for podman machine onboarding e2e tests #13454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

chore(test): remove the skip for podman machine onboarding e2e tests #13454

merged 1 commit into from
Aug 1, 2025

Conversation

odockal
Copy link
Contributor
@odockal odockal commented Jul 31, 2025

What does this PR do?

Remove the skip for podman-machine-onboarding.spec.ts tests on Mac since underlying issue was fixed.

Screenshot / video of UI

What issues does this PR fix or reference?

#13453

How to test this PR?

We need to run it on particular CI.

  • Tests are covering the bug fix or the new feature

@odockal
chore(test): remove the skip for podman machine onboarding e2e tests
7053f71 
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
@odockal odockal requested review from benoitf and a team as code owners July 31, 2025 14:59
@odockal odockal requested review from dgolovin and simonrey1 and removed request for a team July 31, 2025 14:59
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 31, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

The import statement in a test file was updated to remove the unused isMac import, retaining only isLinux. Additionally, a conditional directive that skipped the test suite on MacOS was removed, along with its associated comment referencing a known issue. No changes were made to the test logic or the declarations of exported or public entities.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

area/update

Suggested reviewers

  • benoitf
  • danivilla9
  • ScrewTSW

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6438fc and 7053f71.

📒 Files selected for processing (1)
  • tests/playwright/src/specs/z-podman-machine-onboarding.spec.ts (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings 
Learnt from: benoitf
PR: podman-desktop/podman-desktop#13232
File: packages/api/src/repository-infos.ts:21-21
Timestamp: 2025-07-16T15:41:18.089Z
Learning: In the Podman Desktop project, the `with { type: 'json' }` syntax is the correct modern approach for JSON imports with TypeScript 5.8.3 and Vite, not the older `assert { type: 'json' }` syntax.
📚 Learning: in the podman desktop project, the `with { type: 'json' }` syntax is the correct modern approach for... 
Learnt from: benoitf
PR: podman-desktop/podman-desktop#13232
File: packages/api/src/repository-infos.ts:21-21
Timestamp: 2025-07-16T15:41:18.089Z
Learning: In the Podman Desktop project, the `with { type: 'json' }` syntax is the correct modern approach for JSON imports with TypeScript 5.8.3 and Vite, not the older `assert { type: 'json' }` syntax.

Applied to files:

  • tests/playwright/src/specs/z-podman-machine-onboarding.spec.ts
📚 Learning: in test files for podman desktop, benoitf prefers partial mocking over complete mocking. partial moc... 
Learnt from: benoitf
PR: podman-desktop/podman-desktop#13043
File: packages/main/src/plugin/color-registry-inject.spec.ts:33-35
Timestamp: 2025-07-02T08:26:44.201Z
Learning: In test files for Podman Desktop, benoitf prefers partial mocking over complete mocking. Partial mocks that only implement the methods actually used in the test are sufficient and preferred over creating complete mock objects.

Applied to files:

  • tests/playwright/src/specs/z-podman-machine-onboarding.spec.ts
🔇 Additional comments (2)
tests/playwright/src/specs/z-podman-machine-onboarding.spec.ts (2)

31-31: LGTM! Unused import removed.

The removal of the isMac import is appropriate since it's no longer used after removing the Mac skip condition, aligning with the PR objective to enable tests on Mac.

46-49: Skip logic correctly enables Mac testing.

The current skip condition properly excludes Linux (where podman machine isn't applicable) while allowing tests to run on Mac when TEST_PODMAN_MACHINE=true, which aligns perfectly with the PR objective to enable Mac testing after the underlying issue was fixed.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 31, 2025
View reviewed changes
Copy link
Contributor
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @odockal - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@odockal
Copy link
Contributor Author
odockal commented Aug 1, 2025

Legend: First column: total test cases, Second: Passed, Third: failed, Forth: skipped.
Screenshot_20250801_081703

@odockal
Copy link
Contributor Author
odockal commented Aug 1, 2025 •
edited
Loading

Why are podman-machine-resources tests skipped should be solved in this issue: podman-desktop/e2e#367

@odockal odockal merged commit 9c27052 into podman-desktop:main Aug 1, 2025
21 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.21.0 milestone Aug 1, 2025
@odockal odockal linked an issue Aug 1, 2025 that may be closed by this pull request
Remove a skip for podman machine onboarding on mac after issue was resolved #13453
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@cbr7 cbr7 cbr7 approved these changes

@benoitf benoitf Awaiting requested review from benoitf benoitf is a code owner

@dgolovin dgolovin Awaiting requested review from dgolovin dgolovin is a code owner automatically assigned from podman-desktop/reviewers

@simonrey1 simonrey1 Awaiting requested review from simonrey1 simonrey1 is a code owner automatically assigned from podman-desktop/reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

Remove a skip for podman machine onboarding on mac after issue was resolved
3 participants
@odockal @cbr7 @podman-desktop-bot
0