8000 fix: remove not needed timeout around registerCLITool in compose extension activation by dgolovin · Pull Request #13325 · podman-desktop/podman-desktop · GitHub
[go: up one dir, main page]
Skip to content

fix: remove not needed timeout around registerCLITool in compose extension activation #13325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

fix: remove not needed timeout around registerCLITool in compose extension activation #13325

merged 1 commit into from
Jul 24, 2025

Conversation

dgolovin
Copy link
Contributor

What does this PR do?

PR removes setTimeout call that triggers async function registerCLITool call. setTimeout is not required because async function call without wait does not hold exit from extension's activation function.

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

N/A

How to test this PR?

  • Tests are covering the bug fix or the new feature

@dgolovin
fix: remove not needed timeout around registerCLITool call
a646eba 
Signed-off-by: Denis Golovin <dgolovin@redhat.com>
@dgolovin dgolovin requested review from benoitf and a team as code owners July 24, 2025 00:09
@dgolovin dgolovin requested review from cdrage and gastoner and removed request for a team July 24, 2025 00:09
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 24, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

The update modifies the activation logic in the extension's main TypeScript file by removing the use of setTimeout for deferring the registerCLITool function. Now, registerCLITool is invoked directly within the activate function, with error handling maintained via a .catch block. No changes are made to exported or public interfaces.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • benoitf
  • cdrage

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

extensions/compose/src/extension.ts

Oops! Something went wrong! :(

ESLint: 9.31.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'svelte-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:202:49)

Note

⚡️ Unit Test Generation - Beta

CodeRabbit's unit test generation is now available in Beta! Automatically generate comprehensive unit tests for your code changes, ensuring better test coverage and catching edge cases you might miss. Our AI analyzes your code structure and creates tests that follow best practices and your project's testing patterns. Learn more here, or just try it under ✨ Finishing Touches.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 05b413c and a646eba.

📒 Files selected for processing (1)
  • extensions/compose/src/extension.ts (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: dgolovin
PR: podman-desktop/podman-desktop#13030
File: packages/main/src/plugin/cli-tool-registry.ts:108-113
Timestamp: 2025-07-07T17:23:41.302Z
Learning: CLI tool extensions have two distinct `selectVersion` method definitions: one in the installer (which accepts an optional `latest` parameter) and one in the updater (which has different selection logic). The installer's `selectVersion` method signature is `async (latest?: boolean) => Promise<string>` while the updater's is `async () => Promise<string>`.
extensions/compose/src/extension.ts (1)

Learnt from: dgolovin
PR: #13030
File: packages/main/src/plugin/cli-tool-registry.ts:108-113
Timestamp: 2025-07-07T17:23:41.302Z
Learning: CLI tool extensions have two distinct selectVersion method definitions: one in the installer (which accepts an optional latest parameter) and one in the updater (which has different selection logic). The installer's selectVersion method signature is async (latest?: boolean) => Promise<string> while the updater's is async () => Promise<string>.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: smoke e2e tests (production)
  • GitHub Check: smoke e2e tests (development)
  • GitHub Check: Linux
  • GitHub Check: macOS
  • GitHub Check: linter, formatters
  • GitHub Check: unit tests / macos-15
  • GitHub Check: typecheck
  • GitHub Check: unit tests / ubuntu-24.04
  • GitHub Check: unit tests / windows-2025
  • GitHub Check: Windows
🔇 Additional comments (1)
extensions/compose/src/extension.ts (1)

237-239: LGTM! Simplified async function invocation.

The removal of setTimeout is correct. Directly calling the async function without awaiting it achieves the same non-blocking behavior while simplifying the code. The error handling via .catch is properly maintained.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps u 8000 s grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 24, 2025
View reviewed changes
Copy link
Contributor
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dgolovin - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov Codecov
Copy link
codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

gastoner
gastoner approved these changes Jul 24, 2025
View reviewed changes
Copy link
Contributor
@gastoner gastoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM

@dgolovin dgolovin merged commit 0c9b291 into podman-desktop:main Jul 24, 2025
35 of 36 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.21.0 milestone Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@gastoner gastoner gastoner approved these changes

@benoitf benoitf Awaiting requested review from benoitf benoitf is a code owner

@cdrage cdrage Awaiting requested review from cdrage cdrage is a code owner automatically assigned from podman-desktop/reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dgolovin @gastoner @podman-desktop-bot
0