8000 fix(extension/podman): ensure loop of monitoring can be started at activation of extension by simonrey1 · Pull Request #13275 · podman-desktop/podman-desktop · GitHub
[go: up one dir, main page]
Skip to content

fix(extension/podman): ensure loop of monitoring can be started at activation of extension #13275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2025
Merged

fix(extension/podman): ensure loop of monitoring can be started at activation of extension #13275

merged 3 commits into from
Jul 18, 2025
+10 −4

Conversation

simonrey1
Copy link
Contributor

What does this PR do?

This PR is made to prepare another PR where the monitoring loop is tested. The stop loop is activated in the deactivate method, but it is not desactivated in the activate method. So the test cannot be run as the global stop loop can be modified from another test.

Screenshot / video of UI

What issues does this PR fix or reference?

https://github.com/podman-desktop/podman-desktop/pull/13153/files/ec5af1256af8c61821c3b277af26f5c553cba34d#r2215571950

How to test this PR?

  • Tests are covering the bug fix or the new feature

@simonrey1
fix(extension/podman): ensure loop of monitoring can be started at ac…
d9cb2e7 
…tivation of extension

Signed-off-by: Simon Rey <sfbrey+eqqe@gmail.com>
@simonrey1 simonrey1 requested review from benoitf and a team as code owners July 18, 2025 09:53
@simonrey1 simonrey1 requested review from dgolovin and cdrage and removed request for a team July 18, 2025 09:53
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 18, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

The changes include setting the internal variable stopLoop to false at the beginning of the activate function in the Podman extension to enable monitoring loops upon activation. Additionally, the test teardown was updated to restore real timers after each test. A test case involving concurrent calls to monitorMachines was revised to use fake timers, create and await multiple promises, advance timers asynchronously, and properly await all promises. No exported or public entity signatures were modified.

Possibly related PRs

Suggested labels

area/ci

Suggested reviewers

  • cdrage
  • axel7083
  • benoitf

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

extensions/podman/packages/extension/src/extension.spec.ts

Oops! Something went wrong! :(

ESLint: 9.31.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'svelte-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:202:49)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44c8796 and 03f8173.

📒 Files selected for processing (1)
  • extensions/podman/packages/extension/src/extension.spec.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • extensions/podman/packages/extension/src/extension.spec.ts
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be min 8000 dful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@simonrey1 simonrey1 requested a review from axel7083 July 18, 2025 09:53
sourcery-ai[bot]
sourcery-ai bot reviewed Jul 18, 2025
View reviewed changes
Copy link
Contributor
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eqqe - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@simonrey1 simonrey1 mentioned this pull request Jul 18, 2025
Merged
1 task
axel7083
axel7083 reviewed Jul 18, 2025
View reviewed changes
Copy link
Contributor
@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are failing

@simonrey1
Copy link
Contributor Author

Some tests are failing

I am investigating! It seems like there are side effects between tests in the extension.spec.ts file because they run individually.

@simonrey1
test: fix instability
44c8796 
Signed-off-by: Simon Rey <sfbrey+eqqe@gmail.com>
@simonrey1 simonrey1 requested a review from axel7083 July 18, 2025 13:21
axel7083
axel7083 reviewed Jul 18, 2025
View reviewed changes
axel7083
axel7083 reviewed Jul 18, 2025
View reviewed changes
Copy link
Contributor
@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/podman-desktop/podman-desktop/pull/13275/files/d9cb2e729354714f16ce7eceee40f7cb1c9a81ae..44c87969267f1589bdcc0b7458cae49fbfcbf9be#r2216036279

@simonrey1
test: good practice to make sure called even failed test
03f8173 
Signed-off-by: Simon Rey <sfbrey+eqqe@gmail.com>
@simonrey1 simonrey1 enabled auto-merge (squash) July 18, 2025 13:24
@codecov Codecov
Copy link
codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@simonrey1 simonrey1 merged commit f05b6bb into podman-desktop:main Jul 18, 2025
21 checks passed
@simonrey1 simonrey1 deleted the fix-podman-activation branch July 18, 2025 13:48
@podman-desktop-bot podman-desktop-bot added this to the 1.21.0 milestone Jul 18, 2025
simonrey1 added a commit to simonrey1/podman-desktop that referenced this pull request Jul 21, 2025
@simonrey1
fix(extension/podman): ensure loop of monitoring can be started at ac…
3564ead 
…tivation of extension (podman-desktop#13275)

* fix(extension/podman): ensure loop of monitoring can be started at activation of extension

Signed-off-by: Simon Rey <sfbrey+eqqe@gmail.com>

* test: fix instability

Signed-off-by: Simon Rey <sfbrey+eqqe@gmail.com>

* test: good practice to make sure called even failed test

Signed-off-by: Simon Rey <sfbrey+eqqe@gmail.com>

---------

Signed-off-by: Simon Rey <sfbrey+eqqe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@axel7083 axel7083 axel7083 approved these changes

@benoitf benoitf Awaiting requested review from benoitf benoitf is a code owner

@dgolovin dgolovin Awaiting requested review from dgolovin dgolovin is a code owner automatically assigned from podman-desktop/reviewers

@cdrage cdrage Awaiting requested review from cdrage cdrage is a code owner automatically assigned from podman-desktop/reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simonrey1 @axel7083 @podman-desktop-bot
0