8000 fix(website): vitest did not explore tests in subfolders needed for PR #13182 by simonrey1 · Pull Request #13230 · podman-desktop/podman-desktop · GitHub
[go: up one dir, main page]
Skip to content

fix(website): vitest did not explore tests in subfolders needed for PR #13182 #13230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

fix(website): vitest did not explore tests in subfolders needed for PR #13182 #13230

merged 1 commit into from
Jul 16, 2025

Conversation

simonrey1
8000 Copy link
Contributor

What does this PR do?

fix(website): vitest did not explore tests in subfolders needed for PR #13182

Screenshot / video of UI

What issues does this PR fix or reference?

Needed for PR #13182

How to test this PR?

  • Tests are covering the bug fix or the new feature

@simonrey1 simonrey1 requested review from slemeur, cdrage, benoitf, Firewall and a team as code owners July 16, 2025 12:52
@simonrey1 simonrey1 requested review from SoniaSandler and removed request for a team July 16, 2025 12:52
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented Jul 16, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

The Vitest configuration file was updated to modify the test file inclusion pattern. Previously, the pattern matched test files located only in the root directory. The new pattern now matches test files recursively in all subdirectories, allowing Vitest to include test files from any nested folder within the project. No changes were made to exported or public entity declarations.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

website/vitest.config.js

Oops! Something went wrong! :(

ESLint: 9.31.0

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'svelte-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:202:49)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 616a53f and 1f19d0f.

📒 Files selected for processing (1)
  • website/vitest.config.js (1 hunks)
🔇 Additional comments (1)
website/vitest.config.js (1)

22-22: Approved: Recursive test file discovery pattern is correctly configured

The updated glob **/*.{test,spec}.?(c|m)[jt]s?(x) will match both root-level and nested test files. Verification shows it correctly discovers your existing tests, and if you add tests in subdirectories in the future, they’ll be picked up as intended.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @eqqe - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@benoitf benoitf enabled auto-merge (rebase) July 16, 2025 13:26
@benoitf benoitf merged commit 6301529 into podman-desktop:main Jul 16, 2025
115 of 128 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.21.0 milestone Jul 16, 2025
@simonrey1 simonrey1 deleted the fix-vitest branch July 25, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@benoitf benoitf benoitf approved these changes

@axel7083 axel7083 axel7083 approved these changes

@slemeur slemeur Awaiting requested review from slemeur slemeur is a code owner

@cdrage cdrage Awaiting requested review from cdrage cdrage is a code owner

@Firewall Firewall Awaiting requested review from Firewall Firewall is a code owner

@SoniaSandler SoniaSandler Awaiting requested review from SoniaSandler SoniaSandler is a code owner automatically assigned from podman-desktop/reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@simonrey1 @benoitf @axel7083 @podman-desktop-bot
0