8000 refactor(main): create AppPlugin for window creation by axel7083 · Pull Request #13084 · podman-desktop/podman-desktop · GitHub
[go: up one dir, main page]
Skip to content

refactor(main): create AppPlugin for window creation #13084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

refactor(main): create AppPlugin for window creation #13084

merged 1 commit into from
Jul 8, 2025

Conversation

axel7083
Copy link
Contributor
@axel7083 axel7083 commented Jul 7, 2025

What does this PR do?

When the electron app is ready we call createWindow, and register an activate listener for MacOS. Following the work on #12905, creating a WindowCreation AppPlugin to handle this logic in a separate file.

I added tests for completeness.

What issues does this PR fix or reference?

Fixes #13082

How to test this PR?

  • Tests are covering the bug fix or the new feature

@axel7083
refactor(main): create AppPlugin for window creation
13a7957 
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083 axel7083 requested review from benoitf and a team as code owners July 7, 2025 15:23
@axel7083 axel7083 requested review from dgolovin and gastoner and removed request for a team July 7, 2025 15:23
@coderabbitai coderabbitai

This comment was marked as resolved.

Sign in to view
sourcery-ai[bot]

This comment was marked as resolved.

Sign in to view

coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

@codecov Codecov
Copy link
codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ackages/main/src/plugin/app-ready/window-plugin.ts 89.28% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

gastoner
gastoner approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor
@gastoner gastoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM

@axel7083 axel7083 merged commit 79c74ee into podman-desktop:main Jul 8, 2025
21 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.21.0 milestone Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@coderabbitai coderabbitai[bot] 767D coderabbitai[bot] left review comments

@gastoner gastoner gastoner approved these changes

@benoitf benoitf Awaiting requested review from benoitf benoitf is a code owner

@dgolovin dgolovin Awaiting requested review from dgolovin dgolovin is a code owner automatically assigned from podman-desktop/reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.

refactor(main): moving createNewWindow logic to Main class
3 participants
@axel7083 @gastoner @podman-desktop-bot
0