8000 [core] Reformat SarifLog to comply to coding standards by adangel · Pull Request #5748 · pmd/pmd · GitHub
[go: up one dir, main page]

Skip to content

[core] Reformat SarifLog to comply to coding standards #5748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

adangel
Copy link
Member
@adangel adangel commented May 16, 2025

Describe the PR

The file was originally generated via lombok/delombok. But since we modify it manually now, there is no reason, why it shouldn't comply to PMD's coding style.

  • removed SuppressWarnings
  • use imports instead of fqcn
  • regenerate equals/hashCode with Objects.equals and Objects.hashCode
  • classes are final now
  • removed javadoc on private fields

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

- removed SuppressWarnings
- use imports instead of fqcn
- regenerate equals/hashCode with Objects.equals and Objects.hashCode
- classes are final now
- removed javadoc on private fields

Refs pmd#5662
@adangel adangel added this to the 7.14.0 milestone May 16, 2025
@adangel adangel added the in:pmd-internals Affects PMD's internals label May 16, 2025
Copy link

Documentation Preview

Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.

Regression Tester Report

(comment created at 2025-05-16 19:07:41+00:00 for c928e12)

@adangel adangel merged commit d3cee92 into pmd:main May 30, 2025
12 checks passed
@adangel adangel deleted the core/cleanup-sariflog branch May 30, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:pmd-internals Affects PMD's internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0