-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[WIP] Plotly 3.0.0 - Deep Jupyter Integration, Validation, Performance, and More #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
279 commits
Select commit
Hold shift + click to select a range
9a738c5
Added examples to documentation of standalone utility functions
f55d043
JSLint-cleanup of Figure.js
13ba045
Big refactor of codegen and project output structure
3a972e1
Added back support for subplots and anchor properties with suffix of 1
3773ba9
Some matplotlylib fixes
2c68db5
Some fixes for bullet figure_factor
8756f5e
Review and cleanup of codegen package
c154dd6
merge from ipyplotly_integration
Kully 01d597d
Cleanup/review of basevalidators.py
aea6dfe
Codegen text wrapping refinements
0eeaaa5
Review / cleanup of basedatatypes.py
144325b
Return trace/layout deltas for do_* operations even if source_view_id…
8a7b476
Fix for broken Frame() constructor
45ec084
Added validator tests.
e5eed19
Remove PEP484 type annotations from codegen properties (docstring ins…
69d6b5c
Don't autoimport graph_objs submodules
d537452
Completed review / cleanup of basedatatypes.py
c937f8e
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
Kully ccbd940
Add support for `strict` option to in string validator
1d5db95
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
Kully 5bd77f3
Cleanup / review of basewidget.py
58629de
Cleanup / review of callbacks.py
6f6672e
Cleanup / review of serializers.py: Removed traitlets dependency from…
4e57805
Don't normalize color string during coercion
a62e412
Optimize imports and re-enable recursive submodule imports
b5e4131
Making numpy an optional dependency
b74ff02
When building relayout/restyle strings don't use brackets
53ee212
Dispaatch changes to callbacks after sending udpate messages to the
bd16d77
Don't skip apply relayout/restyle/update operations on view that emit…
2455dc1
make ipywidgets an optional dependency
35bf539
Merge branch 'master' of https://github.com/plotly/plotly.py into ipy…
Kully 06fec5c
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
Kully c6d6540
Add traces with subplots cleanup
a89dcb5
Rework handling of unknown kwargs in datatype classes
ac59d45
Replace use of add_traces for scalar trace with add_trace
920817c
Support deprecated Histogram2dcontour class in Data (traces) validator
5489a89
Add pretty print based __repr__() for BaseFigure and BasePlotlyType
4822f15
Fix FigureWidget frame validation
70e76e1
Leave _frame_objs as empty list (not None) in BaseFigureWidget
4fb462f
Added validator for literal properties (e.g. the 'type' prop of traces)
5740d73
pull from maste
Kully a561275
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
Kully 49e0075
Jupyterlab support!!!!!
1bc4aca
Cleanup js webpack config a little. Remove unused json transform
f140fd8
minor test fixes for ipyplotly_integration (#975)
Kully 90c14eb
WIP property assignment tests
8ad6873
Added tests for compound array assignment (and caught some bugs!)
8836c93
Pass frames param to superclass in BaseFigureWidget, need this for va…
0d3c4fd
Added tests using .update() method, fixed bug when updating compound …
aff9d28
Added BasePlotlyType and BaseLayoutType property tests
687559b
Added figure property tests
d9e2306
Added relayout message tests
c43a349
Make plotly_relayout, plotly_restyle, and plotly_update private
a2c782f
Added support for tuple/dot item syntax on figure
bc19f2f
Added tests for restyle and update messages
af61f25
Added test for batch_animate operation and message
e96abc1
Added message tests for adding traces
df15d14
Cleanup naming of message tests
0543793
Added tests for moving/deleting traces
a7c42f0
Added move/delete traces validation tests
49bc6e8
Added on_change callback tests
503413b
Added test to validate FigureWidget has no frames
b6a6f80
merge 054379335aa0010a5fc895466e1226dcda55dc1a
Kully 11dc3cc
Make plotly_relayout, plotly_restyle, and plotly_update public again
61f4795
Fix param name error in batch_update()/batch_animate()
dbbc6f6
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
Kully 7e7c543
make mock import PyVer dependant
Kully 05c9f39
Handle None in validator present methods
30063d4
Fix webgl plots in JupyterLab!
f150a8c
Test fixes 2 (#994)
Kully e590fd0
use explicit relative imports for py2 compat
Kully af0d247
specified type and instance in super() for scatter attrs//basevalidat…
Kully b86d44b
specify type and instance for super() for codegen code
Kully f0d863d
moved **kwargs to bottom of constructor signatures // super() -> supe…
Kully a88e3d4
road to removing super() and **kwargs codegen changes so CODEGEN proc…
Kully 5d493f9
f0d863d + messing around in basevalidators (CODEGEN works)
Kully e57d5c6
everything works but graph objs and __init__ is deleted
Kully 15cc55b
revert to old schema
Kully bd31ed8
rewrite __dir__ for Layout for Py2 compat
Kully 16a14c0
improve __dir__ again (115) - error in compare_dict is gone
Kully 0dc1999
unicode -> bytes strings in Py2
Kully a873bd9
added __init__ to test_figure_messages//typo//Py2 converts all grabbe…
Kully d52a5f2
figx figure_messages
Kully 56353cd
fixed test_offline
Kully ae20331
optional import reads __init__ matplotlylib file
Kully 8f1513a
remove unneeded import in test_ff
Kully 1af5339
matplotlylib is now importing via optional_imports
Kully 002225a
use six.string_types so unicode doesnt throw error
Kully e9b3f57
matplotlib 2.2.2 - convert unicode to btyte str for matplotlib renderer
Kully 9a38172
improve fullmatch function in basedatatypes
Kully c72da6a
erasing/dealing with some TODOs
Kully d409428
light PEP-8 79 char housekeeping
Kully 0eeae6b
remove py36 from tox test env
Kully 5a1719c
remove graph_objs from SOURCES.txt in plotly.egg
Kully 1d8c4de
remove the lines
Kully b52481a
revert SOURCES.txt edit
Kully eb54590
codegen __init__ pep-8
Kully 48f8239
add graph_objs//rm from gitignore
Kully 2bb78a2
change gitignore
Kully 0a5e227
init and graph_objs.py files
Kully 842c44e
ModuleNotFoundError -> ImportError
Kully cf0a25d
remove plotly/validators from gitignore
Kully 4f07d3a
add init file to figure_widget test in core
Kully d062180
conditional for figurewidget in test_core
Kully 01ff5a5
figurewidget graph_objs test improve
Kully e63eedd
remove Numpy dependancy from test_propery test
Kully 2dfb0f8
comment out up-to-date schema test
Kully 2eac663
added validators file to plotly.egg-info
Kully 361d478
properly comment out class for test_graph_reference
Kully 81dbbc3
remove deprecated classes in figure_factory tests
Kully 2e19cd1
removed deprecated messages in matplotlylib tests
Kully e8de1c6
started removing deprecations in matplotlylib
Kully 20ec3bd
completely removed deprecated messages in matplotlylib
Kully 73928e0
fixed failing matplotlylib tests from last PR
Kully 8997455
deprecations are off of figure_factory module imports
Kully 02e08cb
loosen conditions for data check in offline html
Kully eee449e
remodel the datetime test
Kully f32bb4c
test_utils fixed
Kully c3cf3a4
bump version number
Kully f1b0d76
test_api - removing mock test
Kully a1fbe62
remove all assert_called_once to assert.count == 1 in test_v1
Kully 02ff392
comment out 'assert_called_once' method and add Py2 friendly replacement
Kully 76966c4
remove the commentted assert_called_once calls
Kully 83219df
added py36 to core testing - seeing if tests pass for tox -- -a
Kully bac2430
add py36 to envlist
Kully 60452fd
remove py2.7 and see what happens
Kully 4f666cb
put py2 back in and add py36 to setup classifiers
Kully 1f2e9fd
do a bunch of ls to see what is happening
Kully d7b2dd9
remove py36 from classifiers in setup
Kully 868040a
add figurefactory import
Kully 995e2d0
remove py36 from envlist and circle file
Kully d81357f
remove figure_factory import from last import
Kully b44f184
rewrite install_requires section in setup.py
Kully 86d2942
return install_requires decorator to >=4.0.6 like before
Kully 907f5a8
add _plotly_utils/__init__.py to SOURCES.txt
Kully b9e7587
null change to top_level
Kully c06a8b4
specify decorator
Kully 85ad071
original decorator req
Kully f3fd9c6
add violin dir to setup
Kully dfec10c
all dirs in graph_objs and validators added to setup
Kully 600b7b6
Merge remote-tracking branch 'origin/master' into ipyplotly_integration
jonmmease 287be5b
Convert update_schema into a setup.py command. Convert to run with Py…
jonmmease 2b3fe9d
Code generation updates to support schema changes introduced with SPL…
jonmmease 664c88d
Use proper plotly name for constructing properties (not undercase)
jonmmease f5a5d5a
Download schema for explicitly defined plotly.js version from the plo…
jonmmease 072b89c
Update plotly.js to explicitly defined version by downloading from pl…
jonmmease 4618bd3
Exclude transform data types from code generation (We don't support t…
jonmmease ef62935
Update to plotly.js 1.38.2 (codegen and offline and widget)
jonmmease 3b93e20
compute graph_objs and validator packages recursively for setup.py
jonmmease 095d432
Add warnings import
jonmmease b992c9f
Make recursive package lookup backwards compatible
jonmmease a0df901
fix facet_grid ff - annotations and shapes are now tuples
Kully af779c3
.get handling for layout
Kully bffb1c0
fix pytest validator min/max values test
jonmmease 0fb8600
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
jonmmease 9ee03f7
Allow color array properties to be N-dimensional
jonmmease ea6cb85
Allow data_array types to be multi-dimensional numpy arrays.
jonmmease 0128246
Fix figure cropping problem using plotly.plotly.iplot
jonmmease f5805b5
Add Python 2 string compatibility (treat unicode as a string type)
jonmmease 7617945
Force initial plot width to be chosen based on notebook width.
jonmmease 5444fcc
v3.0.0rc2
chriddyp 88c4bce
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
chriddyp ae64033
Just use six.string_types for string compatibility
jonmmease 968567a
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
jonmmease f03b52e
add virtualenv to gitignore
chriddyp c2999d7
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
chriddyp f279e42
rm .egg-info from git
chriddyp 1b13ecc
rm plotly.egg-info
chriddyp 3315155
Fix __repr__ pretty printer for graph objs and add tests
jonmmease ee5e647
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
jonmmease 663a386
Fix repr for Python 2
jonmmease 2827283
Remove Plotly.Plots.resize call
jonmmease 27567cb
Call newPlot on phosphorjs's 'after-attach' event.
jonmmease b46b7be
Remove the need to manually install widget extension in classic notebook
jonmmease f0a8dbc
v3.0.0rc4
chriddyp d6f628a
Add new toplevel `updateplotlyjs` setup.py command
jonmmease 39fa7e5
Update code generation
jonmmease 72ee40c
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
jonmmease a1d5143
Strip out save_image and save_html methods.
jonmmease 6148b88
Don't break plotly.plot when passed a dict containing a Layout object
jonmmease 3d0460e
Don't error if plotly.js introduces a property not in our schema
jonmmease 8c1c3dc
Handle creation of new subplot objects in response to default properties
jonmmease 562090b
More Python 2 string type fixes
jonmmease e02716d
Don't error if plotly.js introduces a layout property not present in …
jonmmease c0a4098
Python 2 compat. No list.clear()
jonmmease af5a9ef
Better handling for nested lists in validation
jonmmease 4d715d6
v3.0.0rc5
chriddyp 9f63db1
v3.0.0rc6
chriddyp 9754ed6
Update package.json description for widget JS library
jonmmease 06786ae
Update package.json project url
jonmmease 3b648aa
Add js license
jonmmease 827ab6e
Remove trailing slash that was breaking widget install on windows
jonmmease 693e1a2
3.0.0rc7
jonmmease 6e4a272
Convert __repr__() test to use assertEqual for better error messages …
jonmmease 8a22d2a
Fixed bug in on_change callback registration
jonmmease 59e24ae
rc8
jonmmease aefae22
Python 2 fix (keyword parameter not allowed after *args)
jonmmease f3c69cd
Fix on_change callback tests
jonmmease b4e6b01
Added new SrcValidator base class for src properties (e.g. `xsrc`)
jonmmease d4242ac
Python 2 future division for repr test
jonmmease aa1c3cb
3.0.0rc9
jonmmease f38d8d9
Remove test repr cases with numpy arrays for now.
jonmmease eb566a1
comment out not failing test
Kully 83dbc43
getting started on migration-guide.md
Kully cbed6b9
migration guide and editted notebook examples
Kully cc4f53c
testing markdown #
Kully dbbffe3
rough outline of migration guide
Kully 1990218
Added new leading `arg` parameter to all graph obj constructors.
jonmmease 6d06759
Run code generation with the new arg parameter
jonmmease fa659c4
__repr__ refinements
jonmmease 25427cc
migration-guide upgraded
Kully e230527
merge from remote branch
Kully 7ad2a2a
Fix __repr__ for `Frame` objects
jonmmease a50f492
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
jonmmease 9877e1f
Don't initialize `uid` on traces in frames
jonmmease 00ffef4
Fix two errors in recent codegen updates
jonmmease f6a8575
Rerun code generation
jonmmease cd9b614
update installation instructions for migration guide
Kully de23ce0
blurb about doc string for batch animate
Kully 476b8d3
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
Kully 24f6f0d
update pip install in migration guide
Kully 51d79ae
Add contributing.md section on updating plotly.js version
jonmmease 6b889eb
Updated Plotly.js version to 1.38.3
jonmmease 932e6af
Add auto-resizing of figures in JupyterLab when no width/heigh explic…
jonmmease ee26008
Update frontend version to 0.1.1 and remove some duplication
jonmmease f184a94
Added contribution instructions for publishing plotlywidget to npm
jonmmease cad341d
Update version to 3.0.0rc10
jonmmease 069ed58
getting started putting installation in README and rewriting migratio…
Kully 959e24f
fixed up migration-guide
Kully 1cc7234
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
Kully e4bdb5f
add new figure.data section and other things
Kully 2bd87fc
jon's comments
Kully 651b215
updatedd API as it was regenerated
Kully e9edc39
Fix error when displaying default callback.Points object
jonmmease 0e47d11
Add docstring examples of installing hover/unhover/click callbacks
jonmmease 7af6dd0
Merge branch 'ipyplotly_integration' of https://github.com/plotly/plo…
jonmmease 40b31cf
Update version to rc11, but switch to proper semver format '3.0.0-rc.11'
jonmmease 7793c8f
Only send the stable portion of the version in plot.ly requests
jonmmease 2e45a14
Revert version string back to 3.0.0rc11 and use LooseVersion to extra…
jonmmease 6b93527
Add retrying logic from #964 to see if helps "sign in failed" test er…
jonmmease 484c52e
Increate timeout of `tox --notest` command in circle.yml
jonmmease 779e149
Add retrying to setup.py dependencies
jonmmease 69339e2
Don't be picky about the status code on expected PlotlyRequestErrors
jonmmease a439aff
Review and updates to migration guide
jonmmease 43f6236
Reorganize README and add link to migration guide
jonmmease 97547d1
Update changelog for version 3.0.0rc11
jonmmease a04bcaf
Bump retrying's stop_max_delay from 30s to 90s (still hitting CI test…
jonmmease 3fa38e5
Added an example to the docstring of the `on_selection` function
jonmmease 27d3a6f
Updated readme, changelog, and migration guide for 3.0.0 release
jonmmease 9302882
Version 3.0.0
jonmmease File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
update pip install in migration guide
- Loading branch information
commit 24f6f0d3ecce737c2b7e16e9d1ca71a0d8d356d7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no chan
2F7F
ges were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove (See above)