8000 Revert "Remove whitespace. Remove unused variable j." by cldougl · Pull Request #926 · plotly/plotly.py · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@cldougl
Copy link
Member
@cldougl cldougl commented Jan 25, 2018

Reverts #909

some of these changes broke a few of the figure_factory functions and tests
for example: https://github.com/plotly/plotly.py/compare/master...revert-909-pylint-pep8-fixes?expand=1#diff-15c41c129536c7a3b0fd161641855ff3R206 and https://github.com/plotly/plotly.py/compare/master...revert-909-pylint-pep8-fixes?expand=1#diff-83b399f13d8b361d38016264ed1ce589R1055

it might be easier to revert this and reopen the pr running through our tests cc @chriddyp

@chriddyp
Copy link
Member

💃

@cldougl cldougl merged commit 3b32a3d into master Jan 25, 2018
@nicolaskruchten nicolaskruchten deleted the revert-909-pylint-pep8-fixes branch June 19, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0