8000 Do not assign `offsetgroup` to traces in px unless `barmode="group"` by emilykl · Pull Request #4865 · plotly/plotly.py · GitHub
[go: up one dir, main page]
Skip to content

Do not assign offsetgroup to traces in px unless barmode="group" #4865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 18, 2024
Merged

Do not assign offsetgroup to traces in px unless barmode="group" #4865

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
05c7257
do not assign offsetgroup to traces in px for bar, violin, box, and h…
emilykl Nov 12, 2024
b127443
set offsetgroup only in group barmode
emilykl Nov 14, 2024
4e76f58
Limit offsetgroup to Histogram and Bar traces
emilykl Nov 14, 2024
390dfc5
Merge branch 'master' into fix-bar-charts
emilykl Nov 14, 2024
762f17b
also set offsetgroup if no barmode is set
emilykl Nov 14, 2024
ac8af46
boolean order of operations...
emilykl Nov 14, 2024
e41dc36
handle barmode/offsetgroup edge cases
emilykl Nov 14, 2024
2b98cce
formatting
emilykl Nov 14, 2024
e7f3756
formatting
emilykl Nov 14, 2024
3110baa
don't need this
emilykl Nov 15, 2024
ab08bd4
formatting
emilykl Nov 15, 2024
db1e0d9
move set barmode outside trace loop
emilykl Nov 15, 2024
298f5ce
we only need to check barmode in layout_patch, not args
emilykl Nov 15, 2024
ac3177c
change args to layout_patch
emilykl Nov 15, 2024
b195c2e
don't need this
emilykl Nov 15, 2024
b347077
formatting
emilykl Nov 15, 2024
48b8d06
update comment
emilykl Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
handle barmode/offsetgroup edge cases
  • Loading branch information
@emilykl
emilykl committed Nov 14, 2024
commit e41dc36d35c428b00ccece05e994ae6aaea94a6b
12 changes: 9 additions & 3 deletions packages/python/plotly/plotly/express/_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,8 +652,6 @@ def set_cartesian_axis_opts(args, axis, letter, orders):


def configure_cartesian_marginal_axes(args, fig, orders):
if "histogram" in [args["marginal_x"], args["marginal_y"]]:
fig.layout["barmode"] = "overlay"

nrows = len(fig._grid_ref)
ncols = len(fig._grid_ref[0])
Expand Down Expand Up @@ -2147,6 +2145,9 @@ def process_dataframe_timeline(args):
args["x"] = args["x_end"]
args["base"] = args["x_start"]
del args["x_start"], args["x_end"]

args["barmode"] = "relative"

return args


Expand Down Expand Up @@ -2558,8 +2559,13 @@ def make_figure(args, constructor, trace_patch=None, layout_patch=None):
legendgroup=trace_name,
showlegend=(trace_name != "" and trace_name not in trace_names),
)

# With marginal histogram, if barmode is not set, set to "overlay"
if "histogram" in [args.get("marginal_x"), args.get("marginal_y")] and "barmode" not in args:
layout_patch["barmode"] = "overlay"

# Set 'offsetgroup' only in group barmode (or if no barmode is set)
barmode = args.get("barmode")
barmode = args.get("barmode") or layout_patch.get("barmode")
if (
trace_spec.constructor in [go.Bar, go.Box, go.Violin, go.Histogram]
and (barmode == "group" or barmode is None)
Expand Down
0