8000 px.line: don't use webgl if line_shape="spline" is given by bwest2397 · Pull Request #4305 · plotly/plotly.py · GitHub
[go: up one dir, main page]
Skip to content

px.line: don't use webgl if line_shape="spline" is given #4305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 11, 2023
Merged

px.line: don't use webgl if line_shape="spline" is given #4305

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e124216
px.line: don't use webgl for spline shape
bwest2397 Aug 1, 2023
72c4155
Merge branch 'master' into workaround-px-express-line-not-accepting-s…
bwest2397 Sep 14, 2023
04bd8b9
Update packages/python/plotly/plotly/express/_core.py
alexcjohnson Nov 8, 2023
a11a4f5
Merge branch 'master' into workaround-px-express-line-not-accepting-s…
alexcjohnson Nov 8, 2023
2c5fdba
Update CHANGELOG.md
bwest2397 Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
px.line: don't use webgl for spline shape 
If line_shape="spline" is set and render_mode="auto", don't default to
webgl (go.Scattergl) as it doesn't support line_shape="spline".
  • Loading branch information
@bwest2397
bwest2397 committed Aug 1, 2023
commit e12421630d2680c5e8b9319720794fdf1c1f086e
1 change: 1 addition & 0 deletions packages/python/plotly/plotly/express/_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,7 @@ def make_trace_spec(args, constructor, attrs, trace_patch):
or (
args["render_mode"] == "auto"
and len(args["data_frame"]) > 1000
and args["line_shape"] != "spline"
and args["animation_frame"] is None
)
):
Expand Down
0