8000 Do not sort keys during json serialization by jonmmease · Pull Request #3386 · plotly/plotly.py · GitHub
[go: up one dir, main page]
Skip to content

Do not sort keys during json serialization #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 16, 2021
Merged

Do not sort keys during json serialization #3386

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
645ee13
Fixed crash when serializing dict with mix of string and int keys
jonmmease Sep 15, 2021
69ddc67
CHANGELOG
jonmmease Sep 15, 2021
21c7f70
Test fix
jonmmease Sep 15, 2021
46a87bd
Remove layout string test
jonmmease Sep 15, 2021
c25e710
Fix deepcopy/pickle tests
jonmmease Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove layout string test
  • Loading branch information
@jonmmease
jonmmease committed Sep 15, 2021
commit 46a87bd989128aa7d9c648379663872a216de630
1 change: 0 additions & 1 deletion packages/python/plotly/plotly/tests/test_optional/test_offline/test_offline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ def test_default_mpl_plot_generates_expected_html(self):
# just make sure a few of the parts are in here
# like PlotlyOfflineTestCase(TestCase) in test_core
self.assertTrue(data_json in html) # data is in there
self.assertTrue(layout_json in html) # layout is in there too
self.assertTrue(PLOTLYJS in html) # and the source code
# and it's an <html> doc
self.assertTrue(html.startswith("<html>") and html.endswith("</html>"))
0