8000 Return `Figure`, not `dict`. by theengineear · Pull Request #308 · plotly/plotly.py · GitHub
[go: up one dir, main page]
Skip to content

Return Figure, not dict. #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2015
Merged

Return Figure, not dict. #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions plotly/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1651,7 +1651,7 @@ def create_quiver(x, y, u, v, scale=.1, arrow_scale=.3,
data = [quiver]
layout = graph_objs.Layout(hovermode='closest')

return dict(data=data, layout=layout)
return graph_objs.Figure(data=data, layout=layout)

@staticmethod
def create_streamline(x, y, u, v,
Expand Down Expand Up @@ -1759,7 +1759,7 @@ def create_streamline(x, y, u, v,
data = [streamline]
layout = graph_objs.Layout(hovermode='closest')

return dict(data=data, layout=layout)
return graph_objs.Figure(data=data, layout=layout)

@staticmethod
def _make_increasing_ohlc(open, high, low, close, dates, **kwargs):
Expand Down Expand Up @@ -1996,7 +1996,7 @@ def create_ohlc(open, high, low, close,
layout = graph_objs.Layout(xaxis=dict(zeroline=False),
hovermode='closest')

return dict(data=data, layout=layout)
return graph_objs.Figure(data=data, layout=layout)

@staticmethod
def _make_increasing_candle(open, high, low, close, dates, **kwargs):
Expand Down Expand Up @@ -2222,7 +2222,7 @@ def create_candlestick(open, high, low, close,
data = candle_incr_data + candle_decr_data

layout = graph_objs.Layout()
return dict(data=data, layout=layout)
return graph_objs.Figure(data=data, layout=layout)

@staticmethod
def create_distplot(hist_data, group_labels,
Expand Down Expand Up @@ -2402,9 +2402,7 @@ def create_distplot(hist_data, group_labels,
position=0.0))

data = sum(data, [])
dist_fig = dict(data=data, layout=layout)

return dist_fig
return graph_objs.Figure(data=data, layout=layout)


class _Quiver(FigureFactory):
Expand Down
0