Config file safe tests #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, it’s pretty easy to munge them if tests change them!
|
@aneda @chriddyp @cldougl , I'd like to merge this into Neda's branch so that we can be safer about credentials/config files during tests. Right now, they're not isolated. Therefore, a change to these files in one test can cause another one to fail 😞. That's the opposite of unit tests! I think this should fix it. To use this, just inherit from |
About to add session stashing, so it’s helpful to specify which credentials/config we’re stashing/restoring.
|
once tests pass 💃 |
|
@chriddyp , this is failing because master needs to be merged into it, i wrote up a procedure for @aneda here. This is merging into her branch, not master, so I think it will cause fewer conflicts for her to merge this first and then merge master into the Neda, feel free to merge this into your branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some protective isolation of session and file config/credentials between unit tests. This only works when you inherit from the new
TestCase(PlotlyTestCase)