8000 Add button type to updatemenus by rreusser · Pull Request #974 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Add button type to updatemenus #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 26, 2016
Merged

Add button type to updatemenus #974

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
39ab95d
Add button type to updatemenus
rreusser Sep 22, 2016
ddc15fc
Fix a couple updatemenus anchor cases
rreusser Sep 23, 2016
9ee47b1
Fix minor gapbutton issues
rreusser Sep 23, 2016
28fff11
Fix lint errors and another pixel fix for updatemenus
rreusser Sep 23, 2016
fb6adc3
Add showactive attribute to buttons
rreusser Sep 23, 2016
65d71d3
Account for arrow padding in updatemenus
rreusser Sep 23, 2016
7f1d35c
Fix updatemenus descriptions and mocks
rreusser Sep 23, 2016
9a17f69
Fix updatemenus tests
rreusser Sep 23, 2016
68ca4da
Add button dropdown tests
rreusser Sep 23, 2016
f8fba32
Change updatemenus orientation/openreverse to simply 'direction'
rreusser Sep 23, 2016
570a448
Unmangle updatemenus comments
rreusser Sep 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix updatemenus tests
  • Loading branch information
@rreusser
rreusser committed Sep 23, 2016
commit 9a17f69abede6b138cd9b4b1d1be8bbc9430a0fd
10 changes: 5 additions & 5 deletions test/jasmine/tests/updatemenus_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ describe('update menus interactions', function() {

return Plotly.relayout(gd, 'updatemenus[1].buttons[1].label', 'a looooooooooooong<br>label');
}).then(function() {
assertItemDims(selectHeader(1), 179, 34.2);
assertItemDims(selectHeader(1), 179, 35);

return click(selectHeader(1));
}).then(function() {
Expand Down Expand Up @@ -381,21 +381,21 @@ describe('update menus interactions', function() {
assertNodeCount('.' + constants.containerClassName, 1);
assertNodeCount('.' + constants.headerClassName, expectedMenus.length);

var gButton = d3.select('.' + constants.buttonGroupClassName),
var gButton = d3.select('.' + constants.dropdownButtonGroupClassName),
actualActiveIndex = +gButton.attr(constants.menuIndexAttrName),
hasActive = false;

expectedMenus.forEach(function(expected, i) {
if(expected) {
expect(actualActiveIndex).toEqual(i);
assertNodeCount('.' + constants.buttonClassName, expected);
assertNodeCount('.' + constants.dropdownButtonClassName, expected);
hasActive = true;
}
});

if(!hasActive) {
expect(actualActiveIndex).toEqual(-1);
assertNodeCount('.' + constants.buttonClassName, 0);
assertNodeCount('.' + constants.dropdownButtonClassName, 0);
}
}

Expand Down Expand Up @@ -448,7 +448,7 @@ describe('update menus interactions', function() {
}

function selectButton(buttonIndex) {
var buttons = d3.selectAll('.' + constants.buttonClassName),
var buttons = d3.selectAll('.' + constants.dropdownButtonClassName),
button = d3.select(buttons[0][buttonIndex]);
return button;
}
Expand Down
0