8000 Include `scattermapbox` in main bundle by etpinard · Pull Request #816 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Include scattermapbox in main bundle #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2016
Merged

Include scattermapbox in main bundle #816

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee932fb
add 'scattermapbox' to main plotly.js bundle
etpinard Jul 25, 2016
ecb850b
rm temporary 'scattermapbox' register calls in jasmine tests
etpinard Jul 25, 2016
da5a5cd
test: update mapbox mocks (no sure why they changed)
etpinard Aug 4, 2016
4376943
test: don't filter out untestable when pattern is provided
etpinard Aug 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: don't filter out untestable when pattern is provided
  • Loading branch information
@etpinard
etpinard committed Aug 4, 2016
commit 4376943405997f3673db7a4c4b14b427b771503d
8 changes: 4 additions & 4 deletions test/image/compare_pixels_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ if(mockList.length === 0) {
throw new Error('No mocks found with pattern ' + pattern);
}

mockList = mockList.filter(untestableFilter);

if(mockList.length === 0) {
throw new Error('All mocks found with pattern ' + pattern + ' are currently untestable');
// filter out untestable mocks if no pattern is specified
if(!pattern) {
console.log('Filtering out untestable mocks\n');
mockList = mockList.filter(untestableFilter);
}

// main
Expand Down
0