8000 David/enhancement modebar by davidangarita1 · Pull Request #7429 · plotly/plotly.js · GitHub
[go: up one dir, main page]

Skip to content

David/enhancement modebar #7429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 25, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change "a" tag for "button" tag
  • Loading branch information
davidangarita1 committed Jun 3, 2025
commit e557ee15ae6d50e138f0923e9cd2201b26ad9004
3 changes: 2 additions & 1 deletion src/components/modebar/modebar.js
8000
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,9 @@ proto.createGroup = function() {
*/
proto.createButton = function(config) {
var _this = this;
var button = document.createElement('a');
var button = document.createElement('button');

button.setAttribute('type', 'button');
button.setAttribute('tabindex', '0');
button.setAttribute('rel', 'tooltip');
button.className = 'modebar-btn';
Expand Down
3 changes: 2 additions & 1 deletion src/css/_modebar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
cursor: pointer;
line-height: normal;
box-sizing: border-box;

border: none;
background: transparent;
svg {
position: relative;
top: 2px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidangarita1 why did we get rid of this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By converting the anchor to Button they are misaligned, this style is that the buttons icon is centered

Expand Down
0