8000 Fix for #7416: Hidden ticklabels with ticklabelposition "inside" take up plot space by my-tien · Pull Request #7417 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Fix for #7416: Hidden ticklabels with ticklabelposition "inside" take up plot space #7417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Fix for #7416: Hidden ticklabels with ticklabelposition "inside" take up plot space #7417

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
150ccd3
Fixes #7416
my-tien May 6, 2025
684d05c
Update some tests in axes_test.js, because hidden labels no longer ta…
my-tien May 6, 2025
a287e90
Add draftlog for 7417
my-tien May 6, 2025
e157374
Instead of removing text of hidden ticklabels, just set their display…
my-tien May 9, 2025
049b7fe
Fix error: d3 selection.style called as getter
my-tien May 13, 2025
23a29f2
axes_test: Add precision param to new toBeCloseToArray call
my-tien May 13, 2025
8967732
Correct fix for "d3 selection.style called as getter"
my-tien May 13, 2025
10000
2e8db5f
Undo some changes done in 684d05c0 (break the CI)
my-tien May 15, 2025
b546d61
Undo change to left-over failing test since 684d05c0
my-tien May 15, 2025
846c0ab
Try fixing failed baseline test container-colorbar-vertical-w-margin
my-tien May 20, 2025
65fed4a
baseline image for zz-label-spacing
my-tien May 20, 2025
a0affdd
Try fixing automargin behavior when setting display: 'none' for hidde…
my-tien May 22, 2025
930e057
Merge remote-tracking branch 'origin-plotly/master' into label-spacing
my-tien May 22, 2025
b3bc2ae
Merge remote-tracking branch 'origin-plotly/master' into label-spacing
my-tien Jul 4, 2025
4c7f30a
Update baseline images after adjustments for label spacing
my-tien Jul 4, 2025
7d71519
Merge remote-tracking branch 'origin-plotly/master' into label-spacing
my-tien Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try fixing failed baseline test container-colorbar-vertical-w-margin 
- in calculatelabelLevelBbox bbox measurement for hidden labels was broken, because of display none
- display 'none' led to repeated calls of adjustTicklabelOverflow that set display to null, then to none, then to null...
  • Loading branch information
@my-tien
my-tien committed May 20, 2025
commit 846c0ab5fd8c09b9eb21f149a240ab6e3ba49f95
34 changes: 28 additions & 6 deletions src/plots/cartesian/axes.js
View file
Open in desktop
< BF30 td class="blob-code blob-code-addition js-file-line"> // turn on label display temporarily to calculate its bbox
Original file line number Diff line number Diff line change
Expand Up @@ -2946,20 +2946,42 @@ function calcLabelLevelBbox(ax, cls, mainLinePositionShift) {
bottom = -Infinity;
left = Infinity;
right = -Infinity;
var xAxis = ax._id.charAt(0) === 'x';
ax._selections[cls].each(function() {
var thisLabel = selectTickLabel(this);
var hidden = thisLabel.style('display') === 'none';
// Use parent node <g.(x|y)tick>, to make Drawing.bBox
// retrieve a bbox computed with transform info
//
// To improve perf, it would be nice to use `thisLabel.node()`
// (like in fixLabelOverlaps) instead and use Axes.getPxPosition
// together with the makeLabelFns outputs and `tickangle`
// to compute one bbox per (tick value x tick style)
if (hidden) {
thisLabel.style('display', null);
}
var bb = Drawing.bBox(thisLabel.node().parentNode);
top = Math.min(top, bb.top);
bottom = Math.max(bottom, bb.bottom);
left = Math.min(left, bb.left);
right = Math.max(right, bb.right);
if (hidden) {
selectTickLabel(this).style('display', 'none');
}
var currentTop = bb.top;
var currentBottom = bb.bottom;
var currentLeft = bb.left;
var currentRight = bb.right;
if (hidden) {
if (xAxis) {
currentTop = top;
currentBottom = bottom;
} else {
currentLeft = left;
currentRight = right;
}
}
top = Math.min(top, currentTop);
bottom = Math.max(bottom, currentBottom);
left = Math.min(left, currentLeft);
right = Math.max(right, currentRight);
});
} else {
var dummyCalc = axes.makeLabelFns(ax, mainLinePositionShift);
Expand Down Expand Up @@ -3707,8 +3729,8 @@ axes.drawLabels = function(gd, ax, opts) {
var t = thisLabel.select('text');
if(adjust) {
if(hideOverflow) t.style('display', 'none'); // hidden
} else {
t.style('display', null); // visible
} else if(t.node().style.display !== 'none'){
t.style('display', null);

if(side === 'bottom' || side === 'right') {
visibleLabelMin = Math.min(visibleLabelMin, isX ? bb.top : bb.left);
Expand Down
0