8000 Updating baselines for new geodata by emilykl · Pull Request #7406 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content
8000

Updating baselines for new geodata #7406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 23, 2025
Merged

Updating baselines for new geodata #7406

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
33a2e00
add some mocks to blacklist
emilykl Apr 22, 2025
4868250
update baselines for new geodata
emilykl Apr 22, 2025
bce8d21
update blacklist in compare_pixels_test
emilykl Apr 22, 2025
69f104e
make sure slash is added when concatenating topojson path
emilykl Apr 23, 2025
c684b72
use local topojson for image tests
emilykl Apr 23, 2025
362233a
update paths in jasmine geo_test
emilykl Apr 23, 2025
4d37b8c
filter out extra features
emilykl Apr 23, 2025
bb8377b
update image baselines for new geodata
emilykl Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make sure slash is added when concatenating topojson path
  • Loading branch information
@emilykl
emilykl committed Apr 23, 2025
commit 69f104ecbdcfb984a6d86ff8fc9254ff26de4133
6 changes: 5 additions & 1 deletion src/lib/topojson_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ topojsonUtils.getTopojsonName = function(geoLayout) {
};

topojsonUtils.getTopojsonPath = function(topojsonURL, topojsonName) {
return topojsonURL + topojsonName + '.json';
if (topojsonURL.endsWith('/')) {
return topojsonURL + topojsonName + '.json';
} else {
return topojsonURL + '/' + topojsonName + '.json';
}
};

topojsonUtils.getTopojsonFeatures = function(trace, topojson) {
Expand Down
0