8000 Correctly assign click event target in shadow dom by alexcjohnson · Pull Request #7357 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Correctly assign click event target in shadow dom #7357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 17, 2025
Merged

Correctly assign click event target in shadow dom #7357

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e435fdf
Correctly assign click event target in shadow dom
alexcjohnson Feb 8, 2025
f7c3279
draftlog for 7357
alexcjohnson Feb 8, 2025
fe62eb8
loosen click_test slightly so it passes locally
alexcjohnson Feb 8, 2025
e48bc1f
test click events in shadow dom
alexcjohnson Feb 8, 2025
89d6404
Merge branch 'master' into alex/shadow-click
alexcjohnson Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
loosen click_test slightly so it passes locally
  • Loading branch information
@alexcjohnson
alexcjohnson committed Feb 8, 2025
commit fe62eb8b47adfde5161701975339ed3ce6b55a8d
6 changes: 3 additions & 3 deletions test/jasmine/tests/click_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1059,17 +1059,17 @@ describe('Test click interactions:', function() {
width: 600,
height: 600
}).then(function() {
expect(gd.layout.xaxis.range).toBeCloseToArray([1, 2.068]);
expect(gd.layout.xaxis.range).toBeCloseToArray([1, 2.068], 1);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I slightly loosened this test, then this whole file passed locally. I had to look it up, apparently "1" as the second arg means a range of 10^-1, ie a span of 0.1, ie +/- 0.05, whereas the default is +/- 0.005 and I was getting errors of ~0.007.


return doubleClick(300, 300);
})
.then(function() {
expect(gd.layout.xaxis.range).toBeCloseToArray([-0.2019, 3.249]);
expect(gd.layout.xaxis.range).toBeCloseToArray([-0.2019, 3.249], 1);

return doubleClick(300, 300);
})
.then(function() {
expect(gd.layout.xaxis.range).toBeCloseToArray([1, 2.068]);
expect(gd.layout.xaxis.range).toBeCloseToArray([1, 2.068], 1);
})
.then(done, done.fail);
});
Expand Down
0