8000 allow titles to be string in various places by archmoj · Pull Request #7262 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

allow titles to be string in various places #7262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

allow titles to be string in various places #7262

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
192d74b
allow titles to be string, this includes:
archmoj Nov 4, 2024
978b60e
PR log
archmoj Nov 5, 2024
eb711bc
adjust test descriptions
archmoj Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
adjust test descriptions
  • Loading branch information
@archmoj
archmoj committed Nov 5, 2024
commit eb711bcc55dedfe7469f8c5367839fcc2e755779
6 changes: 3 additions & 3 deletions test/jasmine/tests/titles_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe('Plot title', function() {
.then(done, done.fail);
});

it('can still be defined as `layout.title`', function(done) {
it('can be defined as `layout.title`', function(done) {
Plotly.newPlot(gd, data, {title: 'Plotly line chart'})
.then(function() {
expectTitle('Plotly line chart');
Expand Down Expand Up @@ -905,7 +905,7 @@ describe('Titles for multiple axes', function() {

afterEach(destroyGraphDiv);

it('still supports title-as-string', function(done) {
it('supports title-as-string', function(done) {
Plotly.newPlot(gd, data, multiAxesLayout)
.then(function() {
expect(xTitleSel(1).text()).toBe('X-Axis 1');
Expand All @@ -916,7 +916,7 @@ describe('Titles for multiple axes', function() {
.then(done, done.fail);
});

it('can be updated using deprecated title-as-string', function(done) {
it('can be updated using title-as-string', function(done) {
Plotly.newPlot(gd, data, multiAxesLayout)
.then(function() {
return Plotly.relayout(gd, {
Expand Down
0