8000 adjust Biome config to test mocks and format JSON files by archmoj · Pull Request #7106 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

adjust Biome config to test mocks and format JSON files #7106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers a 8000 nd the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 18, 2024
Merged

adjust Biome config to test mocks and format JSON files #7106

merged 6 commits into from
Aug 18, 2024

Conversation

archmoj
Copy link
Contributor
@archmoj archmoj commented Aug 17, 2024

@birkskyum Here I am interested to format the JSON files inside test/image/mock folder.
But I was not able to reformat the files.

Would you mind having a look?

@birkskyum
Copy link
Contributor
birkskyum commented Aug 18, 2024 •
edited
Loading

This seems to work fine (notice the path is /mocks not /mock): npx @biomejs/biome format ./test/image/mocks --write

Made a PR against this branch with the formatted json (1304 files formattet in 0.809s 🚀):

Can you elaborate on what problem you see?

@archmoj archmoj merged commit 5d49246 into master Aug 18, 2024
1 check failed
@archmoj archmoj deleted the mocks-format branch August 18, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @birkskyum
0