8000 Use cimg/node instead of circleci/node by birkskyum · Pull Request #7080 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Use cimg/node instead of circleci/node #7080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 12, 2024
Merged

Use cimg/node instead of circleci/node #7080

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f383256
Use cimg/node instead of circleci/node
birkskyum Aug 9, 2024
8499ead
add draftlog
birkskyum Aug 9, 2024
5c4c7c7
use latest 16.x
birkskyum Aug 9, 2024
590734a
remove &browser-versions
birkskyum Aug 9, 2024
1bc0401
Revert "remove &browser-versions"
birkskyum Aug 9, 2024
9de4616
remove version quotes
birkskyum Aug 9, 2024
e7db5cd
newline in draft
birkskyum Aug 12, 2024
49c3032
quotes
birkskyum Aug 12, 2024
3ab76aa
move 20 versions up for ff
birkskyum Aug 12, 2024
8b886fa
bump firefox
birkskyum Aug 12, 2024
cb19463
bump ff
birkskyum Aug 12, 2024
3bd0369
don't use noFF102
birkskyum Aug 12, 2024
2af1810
Enable test
birkskyum Aug 12, 2024
c01c216
comment out bug in FF
birkskyum Aug 12, 2024
3293402
cleanup
birkskyum Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cleanup
  • Loading branch information
@birkskyum
birkskyum committed Aug 12, 2024
commit 3293402f57de69f1db38e283f3f353197440b3a8
46 changes: 1 addition & 45 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,44 +174,6 @@ jobs:
name: Run jasmine tests (part D)
command: .circleci/test.sh bundle-jasmine

mathjax-firefox101:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: cimg/node:16.20.2-browsers
environment:
# Alaska time (arbitrary timezone to test date logic)
TZ: "America/Anchorage"
working_directory: ~/plotly.js
steps:
- browser-tools/install-browser-tools: &browser-versions
firefox-version: "101.0"
install-chrome: false
install-chromedriver: false
- attach_workspace:
at: ~/
- run:
name: Test MathJax on firefox-101
command: .circleci/test.sh mathjax-firefox

mathjax-firefox102:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: cimg/node:16.20.2-browsers
environment:
# Alaska time (arbitrary timezone to test date logic)
TZ: "America/Anchorage"
working_directory: ~/plotly.js
steps:
- browser-tools/install-browser-tools: &browser-versions
firefox-version: "102.0"
install-chrome: false
install-chromedriver: false
- attach_workspace:
at: ~/
- run:
name: Test MathJax on firefox-102
command: .circleci/test.sh mathjax-firefox102+

mathjax-firefoxLatest:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
Expand All @@ -228,7 +190,7 @@ jobs:
at: ~/
- run:
name: Test MathJax on firefox-latest
command: .circleci/test.sh mathjax-firefox102+
command: .circleci/test.sh mathjax-firefox

make-baselines-virtual-webgl:
parallelism: 8
Expand Down Expand Up @@ -525,12 +487,6 @@ workflows:
- bundle-jasmine:
requires:
- install-and-cibuild
- mathjax-firefox101:
requires:
- install-and-cibuild
- mathjax-firefox102:
requires:
- install-and-cibuild
- mathjax-firefoxLatest:
requires:
- install-and-cibuild
Expand Down
2 changes: 1 addition & 1 deletion .circleci/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ case $1 in
exit $EXIT_STATE
;;

mathjax-firefox102+)
mathjax-firefox)
./node_modules/karma/bin/karma start test/jasmine/karma.conf.js --FF --bundleTest=mathjax --nowatch &&
./node_modules/karma/bin/karma start test/jasmine/karma.conf.js --FF --bundleTest=mathjax --mathjax3 --nowatch &&
./node_modules/karma/bin/karma start test/jasmine/karma.conf.js --FF --bundleTest=mathjax_config --mathjax3 --nowatch &&
Expand Down
0