8000 Fix `isosurface` maximum value calculation when `isomax` is set to null by archmoj · Pull Request #7002 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Fix isosurface maximum value calculation when isomax is set to null #7002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally 8000 send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix isosurface maximum value calculation when isomax is set to null #7002

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1f46f3
fix isosurface _vMax calculation when isomax is null
archmoj May 22, 2024
404979e
log for PR 7002
archmoj May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix isosurface _vMax calculation when isomax is null
  • Loading branch information
@archmoj
archmoj committed May 22, 2024
commit a1f46f3c8739313f30d86ea201115d75b343dd64
2 changes: 1 addition & 1 deletion src/traces/isosurface/calc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ module.exports = function calc(gd, trace) {
trace._minValues = min;
trace._maxValues = max;
trace._vMin = (trace.isomin === undefined || trace.isomin === null) ? min : trace.isomin;
trace._vMax = (trace.isomax === undefined || trace.isomin === null) ? max : trace.isomax;
trace._vMax = (trace.isomax === undefined || trace.isomax === null) ? max : trace.isomax;

colorscaleCalc(gd, trace, {
vals: [trace._vMin, trace._vMax],
Expand Down
0