8000 Hover text bug by cldougl · Pull Request #70 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Hover text bug #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 4, 2015
Merged

Hover text bug #70

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69997b1
or instead of and in showCommonLabel logic
cldougl Dec 2, 2015
b45886f
edit interact tests and add hover label tests
cldougl Dec 3, 2015
9c5a14a
remove white space
cldougl Dec 3, 2015
8e363e5
more hover tests
cldougl Dec 3, 2015
e51e0df
fix for tspans differing on chrome vs firefox
cldougl Dec 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
8000
Diff view
Next Next commit
or instead of and in showCommonLabel logic
  • Loading branch information
@cldougl
cldougl committed Dec 2, 2015
commit 69997b1d185419b55b3cc83498727fabe571cb14
2 changes: 1 addition & 1 deletion src/plots/cartesian/graph_interact.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,7 @@ function createHoverText(hoverData, opts) {
var i, traceHoverinfo;
for (i = 0; i < hoverData.length; i++) {
traceHoverinfo = hoverData[i].trace.hoverinfo;
if (traceHoverinfo.indexOf('all')===-1 &&
if (traceHoverinfo.indexOf('all')===-1 ||
traceHoverinfo.indexOf(hovermode)===-1) {
showCommonLabel = false;
break;
Expand Down
0