-
-
You must be signed in to change notification settings -
Add support for numeric font weight
#6990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
37dee48
Revert "no integer weight"
archmoj 3212866
also drop font-weight 400 when exporting to SVG
archmoj 448eb80
test scatter font weight
archmoj 3a3f458
test bar font weight
archmoj 15b25a5
use numeric font-weight in mocks
archmoj be24a14
skip validating font-weight-bar mock
archmoj d8424a3
draft log
archmoj 353efc4
numeric text weight in gl3d
archmoj abb3fc8
link to include extra valid font-weight options in css-font and gl-text
archmoj 8266a6d
test numeric font-weight values in scattergl pipeline
archmoj 46e6b27
Revert "link to include extra valid font-weight options in css-font a…
archmoj 3e4942a
fall back for unsupported font-weight values
archmoj 72044b5
scattergl numeric font-weight render using bold/normal fallback
archmoj 4d52885
correct mock name
archmoj b92ef23
improve scattergl test
archmoj b125396
test numeric weight in gl2d axis text
archmoj 54005b9
convert typed array spec in integer, number, color, etc
archmoj 09f4dd3
handle typed arrays in scatter3d
archmoj f67b40c
handle typed arrays in gl-axes3d
archmoj 99162e5
handle numeric font weight in mapbox supported fonts
archmoj 990fa8d
fix toSVG using weight: 400
archmoj f3c0356
improve mapbox text weight and italic handling
archmoj a5cc7f8
fix support of Open Sans Extrabold fonts
archmoj 63824c1
test metropolis fonts on mapbox
archmoj 190aef1
test italic Metropolis fonts
archmoj 091e7d3
add weight test for open sans fonts - duplicate simple open-sans base…
archmoj 82de3ff
add weight test for metropolis fonts - duplicate simple metropolis ba…
archmoj 59779f3
Revert "test italic Metropolis fonts"
archmoj f6fcbd7
test numeric weights on axes 3d
archmoj 10f477f
bump gl-axes3d and gl-scatter3d
archmoj 82863fd
refactor src/traces/scattergl/convert.js
archmoj bff00ac
improve font family checks
archmoj 48d057f
add comment
archmoj File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
numeric text weight in gl3d
- Loading branch information
commit 353efc4090727bb486120ad6ebca90679d673a3a
There are no files selected for viewing
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
{ | ||
"data": [ | ||
{ | ||
"type": "scatter3d", | ||
"hovertemplate": "Difficult -0.123456789 | %{text}", | ||
"texttemplate": "Difficult -0.123456789 | %{text}", | ||
"mode": "text", | ||
"text": [ | ||
"1 Minimum", | ||
"100 Thin (Hairline)", | ||
"200 Extra Light (Ultra Light)", | ||
"300 Light", | ||
"400 Normal (Regular)", | ||
"500 Medium", | ||
"600 Semi Bold (Demi Bold)", | ||
"700 Bold", | ||
"800 Extra Bold (Ultra Bold)", | ||
"900 Black (Heavy)", | ||
"950 Extra Black (Ultra Black)", | ||
"1000 Maximum" | ||
], | ||
"textfont": { | ||
"family": "Inter", | ||
"size": 16, | ||
"weight": [ | ||
1, | ||
100, | ||
200, | ||
300, | ||
400, | ||
500, | ||
600, | ||
700, | ||
800, | ||
900, | ||
950, | ||
1000 | ||
] | ||
}, | ||
"z": [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], | ||
"x": [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], | ||
"y": [-5.5, -4.5, -3.5, -2.5, -1.5, -0.5, 0.5, 1.5, 2.5, 3.5, 4.5, 5.5] | ||
} | ||
], | ||
"layout": { | ||
"showlegend": false, | ||
"margin": { | ||
"l": 0, | ||
"r": 0, | ||
"t": 0, | ||
"b": 0 | ||
}, | ||
"scene": { | ||
"xaxis": { | ||
"showticklabels": false, | ||
"showgrid": false, | ||
"zeroline": false | ||
}, | ||
"yaxis": { | ||
"showticklabels": false, | ||
"showgrid": false, | ||
"zeroline": false | ||
}, | ||
"zaxis": { | ||
"showticklabels": false, | ||
"showgrid": false, | ||
"zeroline": false | ||
}, | ||
"aspectratio": { | ||
"x": 1.5, | ||
"y": 1.5, | ||
"z": 1.5 | ||
}, | ||
"camera": { | ||
"projection": { | ||
"type": "orthographic" | ||
}, | ||
"eye": { | ||
"x": 0, | ||
"y": 0, | ||
"z": 10 | ||
}, | ||
"center": { | ||
"x": 0, | ||
"y": 0, | ||
"z": 0 | ||
}, | ||
"up": { | ||
"x": 0, | ||
"y": 1, | ||
"z": 0 | ||
} | ||
} | ||
}, | ||
"width": 400, | ||
"height": 400, | ||
"hovermode": "closest" | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this mock, maybe use a font that has more available weights, to test that they work properly in WebGL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I was interested to test it with the default font as that's what most users use at this moment.