8000 Add "raw" `sizemode` to cone trace by archmoj · Pull Request #6938 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Add "raw" sizemode to cone trace #6938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Add "raw" sizemode to cone trace #6938

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0ae9c7f
add vector sizemode option to cone
archmoj Mar 18, 2024
36ec0e8
update schema test
archmoj Mar 18, 2024
de30fb6
add new test
archmoj Mar 18, 2024
114231e
test sizeref with vector sizemode
archmoj Mar 18, 2024
c85721f
link to changes in gl-cone3d
archmoj Mar 20, 2024
e5be742
update stackgl-bundle
archmoj Mar 20, 2024
5808be2
new mock
archmoj Mar 21, 2024
df7ad45
rename option to raw
archmoj Mar 28, 2024
65da347
bump gl-cone3d 1.6.0 and rebuild stackgl index
archmoj Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update stackgl-bundle
  • Loading branch information
@archmoj
archmoj committed Mar 20, 2024
commit e5be742fee37baf63749e8b26cffc9b1cf7137ee
7 changes: 5 additions & 2 deletions stackgl_modules/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13782,6 +13782,7 @@ module.exports = function(vectorfield, bounds) {
var positionVectors = [];
var vectorScale = Infinity;
var skipIt = false;
var vectorSizemode = vectorfield.coneSizemode === 'vector';
for (var i = 0; i < positions.length; i++) {
var p = positions[i];
minX = Math.min(p[0], minX);
Expand All @@ -13795,7 +13796,7 @@ module.exports = function(vectorfield, bounds) {
if (vec3.length(u) > maxNorm) {
maxNorm = vec3.length(u);
}
if (i) {
if (i && !vectorSizemode) {
// Find vector scale [w/ units of time] using "successive" positions
// (not "adjacent" with would be O(n^2)),
//
Expand Down Expand Up @@ -13834,7 +13835,9 @@ module.exports = function(vectorfield, bounds) {
}
geo.vectorScale = vectorScale;

var coneScale = vectorfield.coneSize || 0.5;
var coneScale = vectorfield.coneSize || (
vectorSizemode ? 1 :0.5
);

if (vectorfield.absoluteConeSize) {
coneScale = vectorfield.absoluteConeSize * invertedMaxNorm;
Expand Down
0