8000 Revise stackgl bundle and add test against undesirable direct changes to `stackgl_modules/index.js` by archmoj · Pull Request #6937 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Revise stackgl bundle and add test against undesirable direct changes to stackgl_modules/index.js #6937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Revise stackgl bundle and add test against undesirable direct changes to stackgl_modules/index.js #6937

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e6122d5
provide dev-deps to bundle stackgl index.js and pin down versions
archmoj Mar 19, 2024
63ee1db
add test-bundle-stackgl
archmoj Mar 19, 2024
9532b80
regenrate stackgl bundle
archmoj Mar 20, 2024
a2986b0
revise stackgl type from umd to commonjs-module
archmoj Mar 20, 2024
b605673
draft log
archmoj Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files. 8000
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revise stackgl type from umd to commonjs-module
  • Loading branch information
@archmoj
archmoj committed Mar 20, 2024
commit a2986b003ad00aff3ad7825b9f3b4bacba6bd619
17 changes: 3 additions & 14 deletions stackgl_modules/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,4 @@
(function webpackUniversalModuleDefinition(root, factory) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The umd header is not required.
It is now simplified to a commonjs module.

if(typeof exports === 'object' && typeof module === 'object')
module.exports = factory();
else if(typeof define === 'function' && define.amd)
define([], factory);
else if(typeof exports === 'object')
exports["Stackgl"] = factory();
else
root["Stackgl"] = factory();
})(self, function() {
return /******/ (function() { // webpackBootstrap
/******/ (function() { // webpackBootstrap
/******/ var __webpack_modules__ = ({

/***/ 1964:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note these index changes are coming from #6665 since between v2.24.2 and v2.24.3.
And there was no need to rebuild the stackgl index since 2.19.0 when is-mobile is updated in #6517.

Expand Down Expand Up @@ -42715,8 +42705,7 @@ function findZeroCrossings(array, level) {
/******/ // Load entry module and return exports
/******/ // This entry module is referenced by other modules so it can't be inlined
/******/ var __webpack_exports__ = __webpack_require__(1964);
/******/ module.exports = __webpack_exports__;
/******/
/******/ return __webpack_exports__;
/******/ })()
;
});
;
3 changes: 1 addition & 2 deletions stackgl_modules/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ module.exports = {
path: path.resolve('.'),
filename: 'index.js',
library: {
name: 'Stackgl',
type: 'umd'
type: 'commonjs-module'
}
},
optimization: {
Expand Down
0