8000 added tabletmode to fire plotly_click event for mobile devices. by NickTominaga · Pull Request #6563 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

added tabletmode to fire plotly_click event for mobile devices. #6563

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2023
Merged

added tabletmode to fire plotly_click event for mobile devices. #6563

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82604eb
added tabletmode to fire plotly_click event for mobile devices.
NickTominaga Apr 12, 2023
735f8f2
eslinted
NickTominaga Apr 12, 2023
2645334
refactored condition for tabletmode
NickTominaga Apr 20, 2023
37df028
Update draftlogs/6563_fix.md
NickTominaga Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update draftlogs/6563_fix.md 
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
  • Loading branch information
@NickTominaga @archmoj
NickTominaga and archmoj authored Apr 21, 2023
commit 37df028691e0fc25f6b3e455210d7351462c7059
3 changes: 2 additions & 1 deletion draftlogs/6563_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- fix condition of `plotly_click` to fire it on touch devices [[#6563](https://github.com/plotly/plotly.js/pull/6563)]
- fix `plotly_click` in gl3d scenes to fire on touch devices [[#6563](https://github.com/plotly/plotly.js/pull/6563)],
with thanks to @NickTominaga for the contribution!
0