8000 Fix cartesian hover toggle by Sizurka · Pull Request #5879 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Fix cartesian hover toggle #5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Fix cartesian hover toggle #5879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
-->
Diff view
Fix cartesian hover toggle 
The hover toggle button couldn't be enabled on cartesian plots because
the later setup completely overwrote the initial allowed groups.  So
just make it add the cartesian buttons instead of replacing the groups
completely.
  • Loading branch information
@Sizurka
Sizurka committed Aug 5, 2021
commit 54159094172fdc3e75b787ea3e5012d1963992ab
2 changes: 1 addition & 1 deletion src/components/modebar/manage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ function getButtonGroups(gd) {
// regardless of what other types are on the plot, since they'll all
// just treat any truthy hovermode as 'closest'
if(hasCartesian) {
hoverGroup = ['toggleSpikelines', 'hoverClosestCartesian', 'hoverCompareCartesian'];
hoverGroup.push('toggleSpikelines', 'hoverClosestCartesian', 'hoverCompareCartesian');
}
if(hasNoHover(fullData) || hasUnifiedHoverLabel) {
hoverGroup = [];
Expand Down
0