remove image viewer - one could use GitHub os vs-code

plotly · archmoj · Jun 25, 2021 · Jun 10, 2021 · Jun 11, 2021 · Jun 10, 2021
commit ff9b12f6869865766ddc3562953575f8fa9f0682
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -229,24 +229,6 @@ Please note that image pixel comparison tests run using circleci/python:3.8.9 do
 Therefore the final baselines may need updates.
 This could simply be done by downloading the `baselines.tar` stored in the `ARTIFACTS` tab of `test-baselines` job (if the test failed).
 
-### Image pixel comparison tests
-
-Image pixel comparison tests are run in a docker container. For more
-information on how to run them locally, please refer to [image test
-README](https://github.com/plotly/plotly.js/blob/master/test/image/README.md).
-
-Running the test locally outputs the generated png images in `build/test_images/` and the png diffs in `build/test_images_diff/` (two git-ignored directories).
-
-To view the image pixel comparison test results, run
-
-```
-npm run start-image_viewer
-```
-
-which shows the baseline image, the generated image, the diff and the json mocks of test cases that failed.
-
-To view the results of a run on CircleCI, download the `build/test_images/` and `build/test_images_diff/` artifacts into your local repo and then run `npm run start-image_viewer`.
-
 ### Using the developer console in karma to write/debug jasmine tests
 
 - Click on the `DEBUG` button

diff --git a/devtools/image_viewer/index.html b/devtools/image_viewer/index.html
diff --git a/devtools/image_viewer/server.js b/devtools/image_viewer/server.js
diff --git a/devtools/image_viewer/viewer.js b/devtools/image_viewer/viewer.js
diff --git a/package.json b/package.json
@@ -47,7 +47,6 @@
     "test-plain-obj": "node tasks/test_plain_obj.js",
     "test": "npm run test-jasmine -- --nowatch && npm run test-bundle && npm run test-image && npm run test-export && npm run test-syntax && npm run lint",
     "start-test_dashboard": "node devtools/test_dashboard/server.js",
-    "start-image_viewer": "node devtools/image_viewer/server.js",
     "start": "npm run start-test_dashboard",
     "baseline": "node test/image/make_baseline.js",
     "noci-baseline": "npm run cibuild && ./tasks/noci_test.sh image && git checkout dist && echo 'Please do not commit unless the change was expected!'",

diff --git a/tasks/util/constants.js b/tasks/util/constants.js
@@ -196,7 +196,6 @@ module.exports = {
     pathToCSSBuild: path.join(pathToBuild, 'plotcss.js'),
 
     pathToTestDashboardBundle: path.join(pathToBuild, 'test_dashboard-bundle.js'),
-    pathToImageViewerBundle: path.join(pathToBuild, 'image_viewer-bundle.js'),
 
     pathToImageTest: pathToImageTest,
     pathToTestImageMocks: path.join(pathToImageTest, 'mocks/'),