8000 Fix bar get color by archmoj · Pull Request #5666 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Fix bar get color #5666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2021
Merged

Fix bar get color #5666

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e95a2c4
fix bar get color when cd has mcc
archmoj May 18, 2021
9a92c48
adjust image test
archmoj May 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix bar get color when cd has mcc
  • Loading branch information
@archmoj
archmoj committed May 18, 2021
commit e95a2c42cfa69820564e90177e6d9ae0d0beb50d
2 changes: 1 addition & 1 deletion src/traces/bar/style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ function getBarColor(cd, trace) {
if(trace.type === 'waterfall') {
return trace[cd.dir].marker.color;
}
return cd.mc || trace.marker.color;
return cd.mcc || cd.mc || trace.marker.color;
}

module.exports = {
Expand Down
0