8000 Label flaky tests and add early returns in setTimeout functions to bypass undefined fullLayouts by archmoj · Pull Request #5482 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Label flaky tests and ad 8000 d early returns in setTimeout functions to bypass undefined fullLayouts #5482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 9, 2021
Merged

Label flaky tests and add early returns in setTimeout functions to bypass undefined fullLayouts #5482

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bb351c8
refactor loop over describe in transition test
archmoj Feb 8, 2021
bc903cc
make one descibe block and use transition duration in test descriptions
archmoj Feb 8, 2021
832ebc2
add flaky tags
archmoj Feb 8, 2021
27c0ac4
early return with void _subplots e.g. afterAll in transition test
archmoj Feb 9, 2021
3c6ec3a
add missing gl tag to splom select test
archmoj Feb 9, 2021
a5f2087
add early return to functions called by setTimeout when gd._fullLayou…
archmoj Feb 9, 2021
85ad874
add three more early returns for destroyed plot
archmoj Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor loop over describe in transition test
  • Loading branch information
@archmoj
archmoj committed Feb 8, 2021
commit bb351c87053deb31d76d1cd3e01057477c6a442e
19 changes: 8 additions & 11 deletions test/jasmine/tests/transition_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,13 @@ var destroyGraphDiv = require('../assets/destroy_graph_div');
var delay = require('../assets/delay');
var mock = require('@mocks/animation');

function runTests(transitionDuration) {
[0, 20].forEach(function(transitionDuration) {
// Run the whole set of tests twice: once with zero duration and once with
// nonzero duration since the behavior should be identical, but there's a
// very real possibility of race conditions or other timing issues.
//
// And of course, remember to put the async loop in a closure:

describe('Plots.transition (duration = ' + transitionDuration + ')', function() {
'use strict';

Expand Down Expand Up @@ -258,17 +264,8 @@ function runTests(transitionDuration) {
.then(done, done.fail);
});
});
}
});

for(var i = 0; i < 2; i++) {
var duration = i * 20;
// Run the whole set of tests twice: once with zero duration and once with
// nonzero duration since the behavior should be identical, but there's a
// very real possibility of race conditions or other timing issues.
//
// And of course, remember to put the async loop in a closure:
runTests(duration);
}

describe('Plotly.react transitions:', function() {
var gd;
Expand Down
0