8000 Drop various methods from Plotly.Fx and Plotly.Plots in the API by archmoj · Pull Request #5420 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Drop various methods from Plotly.Fx and Plotly.Plots in the API #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Drop various methods from Plotly.Fx and Plotly.Plots in the API #5420

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94fd466
simplify Plotly.Fx and Plotly.Plots in the API
archmoj Jan 18, 2021
2feea90
keep sendDataToCloud in Plotly.Plots
archmoj Jan 19, 2021
911b145
use Plotly.plots from the API in plots tests
archmoj Jan 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use Plotly.plots from the API in plots tests
  • Loading branch information
@archmoj
archmoj committed Jan 19, 2021
commit 911b14540b6635bf98e428ed680b5b17f6b732a5
12 changes: 6 additions & 6 deletions test/jasmine/tests/plots_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ describe('Test Plots', function() {
gd.style.width = '400px';
gd.style.height = '400px';

return Plots.re 8000 size(gd);
return Plotly.Plots.resize(gd);
})
.then(done);
});
Expand Down Expand Up @@ -390,7 +390,7 @@ describe('Test Plots', function() {
expect(typeof gd.id).toBe('string');
expect(gd.id).toBeTruthy();

Plots.resize(gd.id)
Plotly.Plots.resize(gd.id)
.then(done, done.fail);
});
});
Expand All @@ -412,7 +412,7 @@ describe('Test Plots', function() {

Plotly.newPlot(gd, [], {})
.then(function() { _assert({l: 74, r: 74, t: 82, b: 66}); })
.then(function() { return Plots.resize(gd); })
.then(function() { return Plotly.Plots.resize(gd); })
.then(function() { _assert({l: 74, r: 74, t: 82, b: 66}); })
.then(done, done.fail);
});
Expand All @@ -428,9 +428,9 @@ describe('Test Plots', function() {
.then(function() {
gd.style.width = '500px';
gd.style.height = '500px';
p.push(Plots.resize(gd));
p.push(Plots.resize(gd));
p.push(Plots.resize(gd));
p.push(Plotly.Plots.resize(gd));
p.push(Plotly.Plots.resize(gd));
p.push(Plotly.Plots.resize(gd));
return Promise.all(p);
})
.then(function(v) {
Expand Down
0