8000 More newPlot calls in tests by archmoj · Pull Request #5393 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

More newPlot calls in tests #5393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 12, 2021
Merged

More newPlot calls in tests #5393

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9fea24b
use newPlot intead of plot in various tests
archmoj Jan 11, 2021
17939fe
increase jasmine timout interval in some gl tests to pass on CI
archmoj Jan 11, 2021
bcb0ce9
add plotly_hover before calling hover in heatmap and contour tests
archmoj Jan 11, 2021
981cc40
use react in geo test when calc data used to be set to undefined
archmoj Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add plotly_hover before calling hover in heatmap and contour tests
  • Loading branch information
@archmoj
archmoj committed Jan 11, 2021
commit bcb0ce9ea8f9dc4458988f3b1fa5887decea1e39
4 changes: 2 additions & 2 deletions test/jasmine/tests/contour_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,13 +639,13 @@ describe('contour hover', function() {
afterAll(destroyGraphDiv);

it('should not display hover on missing data and hoverongaps is disabled', function() {
var pt = _hover(gd, 10, 100)[0];

var hoverData;
gd.on('plotly_hover', function(data) {
hoverData = data;
});

var pt = _hover(gd, 10, 100)[0];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 🤦


expect(hoverData).toEqual(undefined);
expect(pt).toEqual(undefined);
});
Expand Down
4 changes: 2 additions & 2 deletions test/jasmine/tests/heatmap_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -989,13 +989,13 @@ describe('heatmap hover', function() {
afterAll(destroyGraphDiv);

it('should not display hover on missing data and hoverongaps is disabled', function() {
var pt = _hover(gd, 10, 100)[0];

var hoverData;
gd.on('plotly_hover', function(data) {
hoverData = data;
});

var pt = _hover(gd, 10, 100)[0];

expect(hoverData).toEqual(undefined);
expect(pt).toEqual(undefined);
});
Expand Down
0