8000 Add publish test for avoiding function constructors in non-gl(2d|3d) partial bundles by archmoj · Pull Request #5383 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Add publish test for avoiding function constructors in non-gl(2d|3d) partial bundles #5383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 7, 2021
Merged

Add publish test for avoiding function constructors in non-gl(2d|3d) partial bundles #5383

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b54dcc4
test non-gl2d/3d bundles to avoid function constructors
archmoj Jan 6, 2021
4c7ad71
put partial bundle tests in a separate run block
archmoj Jan 7, 2021
c611031
change to exclude pattern - use debug mode
archmoj Jan 7, 2021
4c8b959
find and scan all js files in dist & subfolders
archmoj Jan 7, 2021
3249034
exclude MathJax.js
archmoj Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change to exclude pattern - use debug mode
  • Loading branch information
@archmoj
archmoj committed Jan 7, 2021
commit c611031939f10c64d1afdf2dc9bc0f0207989361
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
8F32
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"watch": "node tasks/watch.js",
"lint": "eslint --version && eslint .",
"lint-fix": "eslint . --fix || true",
"no-new-func": "eslint --no-ignore --no-eslintrc --rule '{no-new-func: error}' dist/plotly-finance.js dist/plotly-basic.js dist/plotly-cartesian.js dist/plotly-geo.js dist/plotly-mapbox.js",
"no-new-func": "eslint --debug --no-ignore --no-eslintrc --rule '{no-new-func: error}' $(ls dist/plotly*.js | grep -v plotly-locale* | grep -v plotly-gl* | grep -v plotly-with-meta.* | grep -v plotly.js | grep -v plotly.min.js)",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Probably don't need debug long-term, right? And I feel like we might as well include the locales in this test, for completeness... we know they're safe but wouldn't hurt to prove it.

"docker": "node tasks/docker.js",
"pretest": "node tasks/pretest.js",
"test-jasmine": "karma start test/jasmine/karma.conf.js",
Expand Down
0