a bit of optimization in choropleth/hover - avoid creating the same a…

…rray multiple times
plotly · archmoj · Nov 18, 2020 · Sep 29, 2020 · Oct 12, 2020 · Oct 21, 2020
commit 76afc6c6ed76327a17cdc0faa4a349112e4a6738
diff --git a/src/traces/choropleth/hover.js b/src/traces/choropleth/hover.js
@@ -19,17 +19,20 @@ module.exports = function hoverPoints(pointData, xval, yval) {
 
     var pt, i, j, isInside;
 
+    var xy = [xval, yval];
+    var altXy = [xval + 360, yval];
+
     for(i = 0; i < cd.length; i++) {
         pt = cd[i];
         isInside = false;
 
         if(pt._polygons) {
             for(j = 0; j < pt._polygons.length; j++) {
-                if(pt._polygons[j].contains([xval, yval])) {
+                if(pt._polygons[j].contains(xy)) {
                     isInside = !isInside;
                 }
                 // for polygons that cross antimeridian as xval is in [-180, 180]
-                if(pt._polygons[j].contains([xval + 360, yval])) {
+                if(pt._polygons[j].contains(altXy)) {
                     isInside = !isInside;
                 }
             }