8000 Fix bar lengths in milliseconds from base by archmoj · Pull Request #4900 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

Fix bar lengths in milliseconds from base #4900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 5, 2020
Merged

Fix bar lengths in milliseconds from base #4900

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4a0b877
add image test for bar with x in milisecond and base
archmoj Jun 3, 2020
2087766
fix milliseconds not to depend on timezone
archmoj Jun 3, 2020
6155965
apply UTC time only to bar length for now
archmoj Jun 4, 2020
118dc82
add Gantt chart mock
archmoj Jun 4, 2020
bff79dc
add jasmine test to lock down issue 4558
archmoj Jun 4, 2020
2ae0fdf
fixups thanks to AJ review
archmoj Jun 5, 2020
bb5bec3
add simple early return
archmoj Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add image test for bar with x in milisecond and base
  • Loading branch information
@archmoj
archmoj committed Jun 3, 2020
commit 4a0b8779f9d7db3894eb88a78df6190c73bd76ba
Binary file added test/image/baselines/bar-with-milliseconds.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
51 changes: 51 additions & 0 deletions test/image/mocks/bar-with-milliseconds.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
{
"data": [
{
"base": [
"2020-02-02 00:00"
],
"orientation": "h",
"type": "bar",
"x": [
86400000
],
"y": [
1
],
"yaxis": "y"
},
{
"base": [
"2020-02-02 00:00"
],
"orientation": "h",
"type": "bar",
"x": [
"1970-01-02 00:00"
],
"y": [
1
],
"yaxis": "y2"
}
],
"layout": {
"width": 800,
"height": 400,
"xaxis": {
"type": "date"
},
"yaxis": {
"domain": [
0,
0.45
]
},
"yaxis2": {
"domain": [
0.55,
1
]
}
}
} 8000
2 changes: 2 additions & 0 deletions test/jasmine/tests/mock_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ var list = [
'bar-like_traces_tozero',
'bar-marker-line-colorscales',
'bar-offsetgroups',
'bar-with-milliseconds',
'basic_area',
'basic_bar',
'basic_error_bar',
Expand Down Expand Up @@ -1176,6 +1177,7 @@ figs['bar-like_traces_no-tozero_stack'] = require('@mocks/bar-like_traces_no-toz
figs['bar-like_traces_tozero'] = require('@mocks/bar-like_traces_tozero');
figs['bar-marker-line-colorscales'] = require('@mocks/bar-marker-line-colorscales');
figs['bar-offsetgroups'] = require('@mocks/bar-offsetgroups');
figs['bar-with-milliseconds'] = require('@mocks/bar-with-milliseconds');
figs['basic_area'] = require('@mocks/basic_area');
figs['basic_bar'] = require('@mocks/basic_bar');
figs['basic_error_bar'] = require('@mocks/basic_error_bar');
Expand Down
0