8000 unified hover: honor layout.hoverlabel by antoinerg · Pull Request #4687 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

unified hover: honor layout.hoverlabel #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 26, 2020
Merged

unified hover: honor layout.hoverlabel #4687

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9faea16
unified hover: use hoverlabel.bgcolor or legend.bgcolor or paperbg_color
antoinerg Mar 25, 2020
576ac60
unified hover: honor hoverlabel.font, then legend.font, then layout.font
antoinerg Mar 25, 2020
76a0488
unified hover: fix for unspecified layout.paperbg_color
antoinerg Mar 25, 2020
531fe79
unified hover: honor hoverlabel.bordercolor, then legend.bordercolor
antoinerg Mar 25, 2020
4ef8205
unified hover: remove extendFlat to handle falsy value for hoverlabel
antoinerg Mar 25, 2020
6483ac9
unified hover: fix inheritance of font attributes
antoinerg Mar 25, 2020
dfd73b8
set Fx defaults after legend defaults so unified hover label can inherit
antoinerg Mar 26, 2020
cc8ca1c
default unified hoverlabel.bgcolor combines legend.bgcolor and paper_…
antoinerg Mar 26, 2020
0d406a0
add comment stating that fx defaults should be set after legend defaults
antoinerg Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unified hover: remove extendFlat to handle falsy value for hoverlabel
  • Loading branch information
@antoinerg
antoinerg committed Mar 25, 2020
commit 4ef8205120ced0858f0f2e7b2afc9a2347975f1d
7 changes: 6 additions & 1 deletion src/components/fx/hoverlabel_defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ module.exports = function handleHoverLabelDefaults(contIn, contOut, coerce, opts
if(!opts.bgcolor && contIn.legend) opts.bgcolor = contIn.legend.bgcolor;
if(!opts.bordercolor && contIn.legend) opts.bordercolor = contIn.legend.bordercolor;
// Merge in decreasing order of importance layout.font, layout.legend.font and hoverlabel.font
opts.font = Lib.extendFlat({}, contIn.font, contIn.legend ? contIn.legend.font : {}, opts.font);

var l = contIn.legend;
if(!opts.font) opts.font = {};
if(!opts.font.size) opts.font.size = l && l.size ? l.size : contIn.font.size;
if(!opts.font.family) opts.font.family = l && l.family ? l.family : contIn.font.family;
if(!opts.font.color) opts.font.color = l && l.color ? l.color : contIn.font.color;
}

coerce('hoverlabel.bgcolor', opts.bgcolor);
Expand Down
0