Fix issue 359 (zoom overlay drawn beneath shapes) #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .then(done); | ||
| }); | ||
|
|
||
| it('should be appended to the the shape layer', function() { |
There was a problem hiding this comment.
you mean: to the zoom layer ?
|
Visual confirmation (mock):
|
| expect(d3.selectAll('.zoomlayer > .zoombox-corners').size()) | ||
| .toEqual(0); | ||
| expect(d3.selectAll('.zoomlayer > .select-outline').size()) | ||
| .toEqual(2); |
There was a problem hiding this comment.
maybe add an assertion after doubleClick making sure that the select-outline are cleared.
|
@n-riesco I made a few minor comments, but this PR looks great. 🍻 to our new shape expert. |
|
Skimming through the numbers made me think this was a case of a comparison with too many digits. I set the precision to This PR is not ready. I need to investigate further the reason for this random failures. |
e2fa52f to
04ef33e
Compare
|
|
This PR is ready again for review/merging. |
| @@ -180,7 +180,9 @@ describe('Test click interactions:', function() { | |||
|
|
|||
| describe('drag interactions', function() { | |||
| beforeEach(function(done) { | |||
| Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(done); | |||
| Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(function() { | |||
| setTimeout(done, 200); | |||
There was a problem hiding this comment.
I think #445 solves the same problem?
|
Looks great! |
cbee319 to
85c9948
Compare
Fixes plotly#359
* Test whether select elements are appended to the zoom layer. * Test whether lasso elements are appended to the zoom layer.
* Ensured the zoombox corners have been removed before emitting 'plotly_deselect' or 'plotly_selected'.
* Test that a double click removes a selection.
85c9948 to
a360992
Compare
* The drag interaction tests in click_test.js may fail when run by `npm run test-jasmine` while they succeed if run by `npm run test-jasmine -- tests/click_test.js`. * These failures disappear when a pause of 200ms is introduced in the `beforeEach` after creating the plot. * Shorter pauses of 0, 10, 20, 50 and 100 ms fail.
This reverts commit 9032cb7.
* In the drag interactions tests, make sure the notifier doesn't hide the drag elements.
|
This PR is ready again for review/merging. |
| var tooltip = document.querySelector('.notifier-note'); | ||
| if(tooltip) tooltip.style.display = 'None'; | ||
|
|
||
| done(); |
There was a problem hiding this comment.
Beautiful. Thanks for figuring this out 🍻
|
@n-riesco Great PR. Thanks! |
etpinard
added a commit
that referenced
this pull request
Jun 28, 2017
- broken since #448 - 🔒 down with test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes from #395 . I couldn't rebase it, and I ended up cherry-picking the commits.
I followed @alexcjohnson 's advice and created a zoom layer between the info and the hover layers.
The PR is ready for review.