Mapbox react updates #4418
Merged
Mapbox react updates #4418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Dec 9, 2019
etpinard
reviewed
Dec 9, 2019
etpinard
reviewed
Dec 9, 2019
That's ok. But next time, please base your PR off your base branch. Here at plotly.js, we're not fans of rebasing and |
|
Thanks for taking a look @etpinard, I'll start looking at adding tests next. |
|
I added a few tests that cover the new functionality Also, it looks like there are some unrelated failures in the image test suite for some webgl chart types. |
|
Awesome work @jonmmease !! 💃 💃 💃 |
|
Thanks for taking the time @etpinard! merging |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes two changes to make updates to mapbox-based plots using
reactsmoother. The use-case I'm working on is a Dash app that uses Datashader to update an image layer in response to eachplotly_relayoutevent.Note: These this branch was initially based on #4413
Change 1: Don't update map position while panning/zooming.
36a2650 prevents plotly.js from updating the mapbox view while a pan/zoom is in process. This fixes the stuttering that occurs when quickly repeating zoom or pan actions.
Before:
After:
Change 2: Use
updateImageto update image, rather than delete and recreate layer.When possible, 7e355d7 uses the mapbox
updateImagefunction to update an existing image in place rather than removing and recreating the source and layer. It also adds theraster-fade-duration: 0paint option (which is suggested by theupdateImagedocstring). Together, these changes remove the image flashing that previously occurred between image updates.Before:
After:
