10000 1d -> 2d -> 1d zoombox regression fix + drag test maintenance by etpinard · Pull Request #3950 · plotly/plotly.js · GitHub
[go: up one dir, main page]
Skip to content

1d -> 2d -> 1d zoombox regression fix + drag test maintenance #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 11, 2019
Merged

1d -> 2d -> 1d zoombox regression fix + drag test maintenance #3950

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8806fb7
generalize assets/drag.js
etpinard Jun 10, 2019
ee74b28
adapt test suites that require assets/drag.js
etpinard Jun 10, 2019
8d0ccb1
fix #3943 - don't mutate fullLayout ax ranges during zoombox mousemove
etpinard Jun 11, 2019
1c92ac7
bump tolerence in multicategory tick label test
etpinard Jun 11, 2019
c48b5bf
use assets/drag.js across test suites
etpinard Jun 11, 2019
4ab4b41
bump tolerence in Drawing.bbox test
etpinard Jun 11, 2019
4511b19
bump tolenrance in sankey suite
etpinard Jun 11, 2019
e676a43
bump delays during legend interactions tests
etpinard Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
bump delays during legend interactions tests 
... to alleviate problems when running full `npm run test-jasmine`
    suite at once.
  • Loading branch information
@etpinard
etpinard committed Jun 11, 2019
commit e676a43d84ce2927d5e66623b7381e968ab37fd2
8 changes: 5 additions & 3 deletions test/jasmine/tests/legend_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1260,7 +1260,7 @@ describe('legend interaction', function() {
item.dispatchEvent(new MouseEvent('mousedown'));
item.dispatchEvent(new MouseEvent('mouseup'));
}
setTimeout(resolve, DBLCLICKDELAY + 20);
setTimeout(resolve, DBLCLICKDELAY + 100);
});
};
}
Expand Down Expand Up @@ -1682,6 +1682,7 @@ describe('legend interaction', function() {
'legend.itemdoubleclick': false
});
})
.then(delay(100))
.then(click(0, 1)).then(_assert([true, true, true]))
.then(click(0, 2)).then(_assert([true, true, true]))
.then(function() {
Expand All @@ -1690,6 +1691,7 @@ describe('legend interaction', function() {
'legend.itemdoubleclick': 'toggle'
});
})
.then(delay(100))
.then(click(0, 1)).then(_assert([true, 'legendonly', 'legendonly']))
.then(click(0, 1)).then(_assert([true, true, true]))
.then(click(0, 2)).then(_assert(['legendonly', true, true]))
Expand All @@ -1707,7 +1709,7 @@ describe('legend interaction', function() {
.then(run)
.catch(failTest)
.then(done);
});
}, 2 * jasmine.DEFAULT_TIMEOUT_INTERVAL);

it('- pie case', function(done) {
_assert = function(_exp) {
Expand All @@ -1728,7 +1730,7 @@ describe('legend interaction', function() {
.then(run)
.catch(failTest)
.then(done);
});
}, 2 * jasmine.DEFAULT_TIMEOUT_INTERVAL);
});
});
});
Expand Down
0